-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33376/
-----------------------------------------------------------
(Updated April 21, 2015, 7:06 p.m.)
Review request for mesos and Joris Van Remoortere.
Changes
-------
Addressed Joris comments
Bugs: MESOS-2633
https://issues.apache.org/jira/browse/MESOS-2633
Repository: mesos
Description
-------
Created new file framework.cpp containing all the methods' implementations for
the `Framework` class (declared in master/master.hpp)
Declared `operator ==` for Task in type_utils.hpp
(it was implemented before, but not declared in the header file);
Refactored all the LOG(WARNING) to a single utility method.
Diffs (updated)
-----
.gitignore-template 1a8e2a8677a29f06ba6386d56537a0013d38821c
include/mesos/type_utils.hpp cdf5864389a72002b538c263d70bcade2bdffa45
src/Makefile.am d15a37365bcdd5c3906160b46b389635b38b1673
src/master/framework.cpp PRE-CREATION
src/master/master.hpp c10e7c08c191acef9d31d98018a47a2a952a4dfc
Diff: https://reviews.apache.org/r/33376/diff/
Testing
-------
All tests (make check) pass.
Thanks,
Marco Massenzio