Note that we will want to keep the library checks in addition. This should
ideally just update / replace all the "Check for what compiler it is",
which we use when setting the various needed additional compiler flags
(-Wno-unused-local-typedef{s} primarily).On Mon, Apr 27, 2015 at 9:37 AM, James Peach <[email protected]> wrote: > > > On Apr 26, 2015, at 12:17 PM, Benjamin Hindman <[email protected]> > wrote: > > > > That would be great James! We took an MVP approach for now, but it would > be > > great if we could give even better error messages or warning messages for > > compilers that we don't regularly test or work with. > > OK, I’ll take a crack at is in MESOS-2666 > > > > > On Sun, Apr 26, 2015 at 11:51 AM, James Peach <[email protected]> wrote: > > > >> On Apr 25, 2015, at 4:24 PM, [email protected] wrote: > >>> > >>> Warn if g++ < 4.8 or a C++ standard library is too old for Mesos. > >>> > >>> After this a whole bunch more of the C++11 checks can be removed, we > >>> can unconditionally use -std=c++11, among other things with this > >>> change. > >>> > >>> Note that we don't explicitly check the clang version number since > >>> extracting it is hard (OS X clang behaves differently than Linux > >>> clang), and 'clang -dumpversion' always reports 4.2.1 for > >>> compatibility with some random tools that used GCC. > >> > >> Would it make sense to use AX_COMPILER_VENDOR and AX_COMPILER_VERSION > here? > >> > >> > >> http://www.gnu.org/software/autoconf-archive/ax_compiler_vendor.html > >> > >> http://www.gnu.org/software/autoconf-archive/ax_compiler_version.html > >> > >> J > >> > >
