I'm a +1 on this so long as you follow up with all of the necessary include changes. :) BenH was probably the one that initially enacted this style, so I've cc'ed him to see if there was intention behind it.
It should be pointed out that this rule doesn't apply to all .cpp files, yes? (e.g. tests don't have a corresponding header). On Wed, Apr 29, 2015 at 1:35 PM, Jörg Schad <jo...@mesosphere.io> wrote: > I would like to propose that regarding the header include order we follow > the Google Styleguide completely. We currently have an undocumented > exception in that we do not include direct headers first in the > corresponding implementation files (i.e. abc.hpp -> abc.cpp). > > The reasons, and examples for this are outlined in the Jira here: > https://issues.apache.org/jira/browse/MESOS-2673 > > Please feel free to comment here on the dev-list, but also consider to > comment on the Review Request directly! > > Thanks for your feedback, > Jörg >
