I'll volunteer to shepherd this, unless somebody else really wants to. I think returning any HTTP error code (other than 200 OK) would be preferable for those endpoints that would return empty data otherwise, but redirect is the most actionable one for getting to the real data.
On Wed, Jul 1, 2015 at 1:22 AM, Alex Rukletsov <[email protected]> wrote: > Hi Haosdent, > > Do you have a shepherd for this change? > On 1 Jul 2015 8:06 am, "Adam Bordelon" <[email protected]> wrote: > > > The original ticket MESOS-1865 > > <https://issues.apache.org/jira/browse/MESOS-1865> argues the point that > > requesting state data (e.g. tasks.json) from a non-leading master should > > not return 200 OK status code with empty data, as that is misleading. It > > should either return an error code, or valid data. A redirect response > can > > be interpreted by the requester as an error ("not the leading master"), > or > > used to request the valid data from the leading master. > > > > On Tue, Jun 30, 2015 at 9:12 PM, Tomás Senart <[email protected]> > wrote: > > > > > Hi Haosdent, > > > > > > Thanks for the heads up. Would you be able to share the rationale for > > this > > > change? Is it a precursor for something else? > > > > > > Best, > > > Tomás > > > On Tue 30 Jun 2015 at 19:24 haosdent <[email protected]> wrote: > > > > > > > Hi All, > > > > > > > > We intend to introduce a breaking change[1] in the http endpoints. > For > > > > below http endpoints, when user request to a master which is not a > > > leader, > > > > user would got a 302 redirect to the leader master. > > > > * /slaves > > > > * /state > > > > * /stateSummary > > > > * /roles > > > > * /teardown > > > > * /tasks > > > > For other endpoints in master, the behaviour is not change. If your > > > > existing framework relied on this behaviour, I suggest add a logic to > > > > handle 302 redirect response. Let me know if you have any > > > queries/concerns. > > > > Thank you very much. > > > > > > > > Links: > > > > [1] Tracking JIRA: https://issues.apache.org/jira/browse/MESOS-1865 > > > > > > > > > > > > -- > > > > Best Regards, > > > > Haosdent Huang > > > > > > > > > >
