Tim, maybe just remove CgroupsCpushareIsolatorProcess from CgroupsIsolatorTypes and add a TODO there for this release?
We can definitely work around it (like you said). - Jie On Thu, Aug 27, 2015 at 4:05 PM, Timothy Chen <[email protected]> wrote: > That test is failing because of a wierd bug in CentOS 7 not naming the > cgroups correctly (or at least not following the pattern every other > OS). > > I filed a CentOS bug but no response so far, if we want to fix it we > will have to work around this problem by hardcoding another cgroup > name to test cpuacct,cpu. > > Tim > > On Thu, Aug 27, 2015 at 4:00 PM, Vinod Kone <[email protected]> wrote: > > Happy to cut another RC. > > > > IIUC, https://reviews.apache.org/r/37684 doesn't fix the below test. > > > > [ FAILED ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup, where > > TypeParam = mesos::internal::slave::CgroupsCpushareIsolatorProcess > > > > Is someone working on fixing that (MESOS-3294 > > <https://issues.apache.org/jira/browse/MESOS-3294>)? If yes, I would > wait a > > day or two to get that in. > > > > Any other issues people have encountered with RC1? > > > > > > > > On Thu, Aug 27, 2015 at 3:45 PM, Niklas Nielsen <[email protected]> > > wrote: > > > >> If it is that easy to fix, why not get it in? > >> > >> How about https://issues.apache.org/jira/browse/MESOS-3053 (which > >> Haosdent ran into)? > >> > >> On 27 August 2015 at 15:36, Jie Yu <[email protected]> wrote: > >> > >>> Niklas, > >>> > >>> This is the known problem reported by Marco. I am OK with both because > >>> the linux filesystem isolator cannot be used in 0.24.0. > >>> > >>> If you guys prefer to cut another RC, here is the patch that needs to > be > >>> cherry picked: > >>> > >>> commit 3ecd54320397c3a813d555f291b51778372e273b > >>> Author: Greg Mann <[email protected]> > >>> Date: Fri Aug 21 13:21:10 2015 -0700 > >>> > >>> Added symlink test for /bin, lib, and /lib64 when preparing test > root > >>> filesystem. > >>> > >>> Review: https://reviews.apache.org/r/37684 > >>> > >>> > >>> > >>> On Thu, Aug 27, 2015 at 3:30 PM, Niklas Nielsen <[email protected]> > >>> wrote: > >>> > >>>> -1: sudo make check on centos 7 > >>>> > >>>> [----------] Global test environment tear-down > >>>> > >>>> [==========] 793 tests from 121 test cases ran. (606946 ms total) > >>>> > >>>> [ PASSED ] 786 tests. > >>>> > >>>> [ FAILED ] 7 tests, listed below: > >>>> > >>>> [ FAILED ] UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup, where > >>>> TypeParam = mesos::internal::slave::CgroupsCpushareIsolatorProcess > >>>> > >>>> [ FAILED ] LinuxFilesystemIsolatorTest.ROOT_ChangeRootFilesystem > >>>> > >>>> [ FAILED ] LinuxFilesystemIsolatorTest.ROOT_VolumeFromSandbox > >>>> > >>>> [ FAILED ] LinuxFilesystemIsolatorTest.ROOT_VolumeFromHost > >>>> > >>>> [ FAILED ] > >>>> LinuxFilesystemIsolatorTest.ROOT_VolumeFromHostSandboxMountPoint > >>>> > >>>> [ FAILED ] > >>>> LinuxFilesystemIsolatorTest.ROOT_PersistentVolumeWithRootFilesystem > >>>> > >>>> [ FAILED ] MesosContainerizerLaunchTest.ROOT_ChangeRootfs > >>>> > >>>> Configured with: > >>>> > >>>> ../mesos/configure --prefix=/home/vagrant/releases/0.24.0/ > >>>> --disable-python > >>>> > >>>> On 26 August 2015 at 17:00, Khanduja, Vaibhav < > [email protected]> > >>>> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> > On Aug 26, 2015, at 4:43 PM, Vinod Kone <[email protected]> > wrote: > >>>>> > > >>>>> > Pinging the thread for more (binding) votes. Hopefully people have > >>>>> caught > >>>>> > up with emails after Mesos madness. > >>>>> > > >>>>> >> On Wed, Aug 19, 2015 at 1:28 AM, haosdent <[email protected]> > >>>>> wrote: > >>>>> >> > >>>>> >> +1 > >>>>> >> > >>>>> >> OS: Ubutnu 14.04 > >>>>> >> Verify command: sudo make -j8 check > >>>>> >> Compiler: Both gcc4.8 and clang3.5 > >>>>> >> Configuration: default configuration > >>>>> >> Result: all tests(828 tests) pass > >>>>> >> > >>>>> >> MESOS-3053 <https://issues.apache.org/jira/browse/MESOS-3053> is > >>>>> because > >>>>> >> need update add iptable first. > >>>>> >> > >>>>> >>> On Wed, Aug 19, 2015 at 2:39 PM, haosdent <[email protected]> > >>>>> wrote: > >>>>> >>> > >>>>> >>> Could not > >>>>> >>> pass DockerContainerizerTest.ROOT_DOCKER_Launch_Executor_Bridged > in > >>>>> Ubuntu > >>>>> >>> 14.04. Already have a issue for this > >>>>> >>> https://issues.apache.org/jira/browse/MESOS-3053, it is > acceptable? > >>>>> >>> > >>>>> >>> On Wed, Aug 19, 2015 at 12:55 PM, Marco Massenzio < > >>>>> [email protected]> > >>>>> >>> wrote: > >>>>> >>> > >>>>> >>>> +1 (non-binding) > >>>>> >>>> > >>>>> >>>> All tests (including ROOT) pass on: > >>>>> >>>> Ubuntu 14.04 (physical box) > >>>>> >>>> > >>>>> >>>> All non-ROOT tests pass on: > >>>>> >>>> CentOS 7 (VirtualBox VM) > >>>>> >>>> > >>>>> >>>> Known issue (MESOS-3050) for ROOT tests on CentOS 7, > non-blocker. > >>>>> >>>> > >>>>> >>>> Thanks, > >>>>> >>>> > >>>>> >>>> *Marco Massenzio* > >>>>> >>>> > >>>>> >>>> *Distributed Systems Engineerhttp://codetrips.com < > >>>>> http://codetrips.com>* > >>>>> >>>> > >>>>> >>>> On Tue, Aug 18, 2015 at 3:26 PM, Vinod Kone < > [email protected]> > >>>>> >>>> wrote: > >>>>> >>>> > >>>>> >>>>> 0.24.0 includes the following: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > -------------------------------------------------------------------------------- > >>>>> >>>>> > >>>>> >>>>> Experimental support for v1 scheduler HTTP API! > >>>>> >>>>> > >>>>> >>>>> This release also wraps up support for fetcher. > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The CHANGELOG for the release is available at: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.24.0-rc1 > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > -------------------------------------------------------------------------------- > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The candidate for Mesos 0.24.0 release is available at: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://dist.apache.org/repos/dist/dev/mesos/0.24.0-rc1/mesos-0.24.0.tar.gz > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The tag to be voted on is 0.24.0-rc1: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.24.0-rc1 > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The MD5 checksum of the tarball can be found at: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://dist.apache.org/repos/dist/dev/mesos/0.24.0-rc1/mesos-0.24.0.tar.gz.md5 > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The signature of the tarball can be found at: > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://dist.apache.org/repos/dist/dev/mesos/0.24.0-rc1/mesos-0.24.0.tar.gz.asc > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The PGP key used to sign the release is here: > >>>>> >>>>> > >>>>> >>>>> https://dist.apache.org/repos/dist/release/mesos/KEYS > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The JAR is up in Maven in a staging repository here: > >>>>> >>>>> > >>>>> >>>>> > >>>>> > https://repository.apache.org/content/repositories/orgapachemesos-1064 > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> Please vote on releasing this package as Apache Mesos 0.24.0! > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> The vote is open until Fri Aug 21 15:24:05 PDT 2015 and passes > if > >>>>> a > >>>>> >>>>> majority of at least 3 +1 PMC votes are cast. > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> [ ] +1 Release this package as Apache Mesos 0.24.0 > >>>>> >>>>> > >>>>> >>>>> [ ] -1 Do not release this package because ... > >>>>> >>>>> > >>>>> >>>>> > >>>>> >>>>> Thanks, > >>>>> >>>>> > >>>>> >>>>> Vinod > >>>>> >>> > >>>>> >>> > >>>>> >>> -- > >>>>> >>> Best Regards, > >>>>> >>> Haosdent Huang > >>>>> >> > >>>>> >> > >>>>> >> > >>>>> >> -- > >>>>> >> Best Regards, > >>>>> >> Haosdent Huang > >>>>> >> > >>>>> > >>>> > >>>> > >>> > >> >
