fixed — *Joris Van Remoortere* Mesosphere
On Tue, Nov 10, 2015 at 9:53 PM, James Peach <[email protected]> wrote: > > > On Nov 9, 2015, at 10:25 AM, [email protected] wrote: > > > > Added JSON parsing for Resources. > > > > > > [snip] > > > > http://git-wip-us.apache.org/repos/asf/mesos/blob/62f17731/src/tests/resources_tests.cpp > > ---------------------------------------------------------------------- > > diff --git a/src/tests/resources_tests.cpp > b/src/tests/resources_tests.cpp > > index 209d708..e663f5e 100644 > > --- a/src/tests/resources_tests.cpp > > +++ b/src/tests/resources_tests.cpp > > @@ -160,6 +160,577 @@ TEST(ResourcesTest, ParsingFromJSON) > > ASSERT_SOME(parse); > > > > > > [snip] > > > + EXPECT_EQ(Value::RANGES, ports->type()); > > + EXPECT_EQ(2, ports->ranges().range_size()); > > + > > + // Do not specify the ordering of ranges, only check the values. > > + if (10000 != ports->ranges().range(0).begin()) { > > + EXPECT_EQ(30000, ports->ranges().range(0).begin()); > > + EXPECT_EQ(10000, ports->ranges().range(1).begin()); > > + } else { > > + EXPECT_EQ(30000, ports->ranges().range(1).begin()); > > + } > > GCC 4.9.2 really wants unsigned constants here ... > > CXX tests/mesos_tests-resources_tests.o > In file included from > /opt/home/src/mesos.git/src/tests/resources_tests.cpp:23:0: > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h: > In instantiation of ‘testing::AssertionResult > testing::internal::CmpHelperEQ(const char*, const char*, const T1&, const > T2&) [with T1 = int; T2 = long unsigned int]’: > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1485:30: > required from ‘static testing::AssertionResult > testing::internal::EqHelper<lhs_is_null_literal>::Compare(const char*, > const char*, const T1&, const T2&) [with T1 = int; T2 = long unsigned int; > bool lhs_is_null_literal = false]’ > /opt/home/src/mesos.git/src/tests/resources_tests.cpp:219:5: required > from here > ../3rdparty/libprocess/3rdparty/gmock-1.7.0/gtest/include/gtest/gtest.h:1448:16: > error: comparison between signed and unsigned integer expressions > [-Werror=sign-compare] > if (expected == actual) { > ^ > > J > >
