I will. I think Joseph can (and already has) help review this.

—
*Joris Van Remoortere*
Mesosphere

On Tue, Dec 22, 2015 at 11:02 AM, James Peach <[email protected]> wrote:

> Hi all,
>
> Can anyone shepherd https://issues.apache.org/jira/browse/MESOS-3909?
>
> Mesos modules depend on picojson, which AFAICT is not included in any
> distributions. This change installs picojson.h if Mesos was built with the
> bundled picojson (99% of cases IMHO). Even if you bring your own
> piconjson.h, I think this is required for correct builds since it would
> otherwise be possible for the version you use in your module to be
> mismatched with the version compiled into Mesos.
>
> Since picojson is an implementation detail of stout/json.hpp, I don't
> really think it should be exposed at all, but that would require stout to
> be a full library (not header-only).
>
> thanks,
> James

Reply via email to