You'll need to shorten your commit summary, which is derived from the 'Summary' field in ReviewBoard. You can put a longer description in the 'Description' field, and it will also be included in the final commit message (although not in the first line, which is restricted to 72 chars).
Also, since the patch's summary ends up being the commit message, please phrase it in terms of what you did to fix the problem, rather than just restating the problem without a solution. For example: "Added timestamp to DockerContainerizer's ResourceStatistics." On Thu, Jan 14, 2016 at 4:36 AM, pangbingqiang <pangbingqi...@huawei.com> wrote: > Thanks! Yeah, the hooks dir have a commit-msg file, so what I should do to > fix this? The file line no more than 72 chars. > > -----邮件原件----- > 发件人: Benjamin Bannier [mailto:benjamin.bann...@mesosphere.io] > 发送时间: 2016年1月14日 20:20 > 收件人: dev@mesos.apache.org > 主题: Re: Request Mesos contributor role > > Hi, > > >> Error: > >> 2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ > >> [612/612] -> "42288.patch" [1] Total errors found: 0 Checking 1 files > >> Error: Commit message summary (the first line) must not exceed 72 > characters. > > > >> my patch first line is: > >> diff --git a/src/slave/containerizer/docker.cpp > >> b/src/slave/containerizer/docker.cpp > > > >> how could I to fix this? > > This refers to the commit message, > > Docker container REST API /monitor/statistics.json output have no > timestamp field > > which is too long (I count 81 chars, but a hard max is put at 72 chars); > the same automated check also rejects commit summaries not ending in a > period `.`. Additionally, a human reviewer will likely ask you to use past > tense (e.g., “Fixed … for …”). > > If you rerun `bootstrap` from the project root it should install local git > hooks so that the same checks are run locally on your machine while you > develop. > > > HTH, > > Benjamin >
