How about rename submitting-a-patch to CONTRIBUTING.md or create CONTRIBUTING.md which would show when user create pull request in github? Furthermore, because I saw we also submit doc through Review board, how about disable pull request in Github which let user confuse?
On Wed, Feb 3, 2016 at 4:41 AM, Hegner, Travis <[email protected]> wrote: > OK then, Thanks. > > Consider this message a formal request for contributor permissions so that > I can assign the JIRA to myelf. > > Travis > > -----Original Message----- > From: Kapil Arya [mailto:[email protected]] > Sent: Tuesday, February 2, 2016 3:04 PM > To: dev <[email protected]> > Subject: Re: Shephard Reqeust: patch for MESOS-4370 > > Thanks for the explanation, Greg!! > > Travis, > > Thanks for contributing to Mesos. Please go through the contributor > guidelines as suggested by Greg. I can then shepherd the patch for you. > > Best, > Kapil > > > On Tue, Feb 2, 2016 at 2:56 PM, Greg Mann <[email protected]> wrote: > > Hi Travis, > > Thanks for your contribution! It's always great to see new > > contributors :-) > > > > A couple things regarding your patch: > > Please have a look at the contribution guidelines here: > > http://mesos.apache.org/documentation/latest/submitting-a-patch/ > > > > The standard protocol when addressing a JIRA issue is to assign the > > issue to yourself on JIRA, and then find a "Shepherd" for the ticket > > before coding begins. The shepherd is a Mesos committer who will work > > with you to design the patch, and then commit it once it's complete. > > > > It also looks like the ticket you've been working on is currently in > > the "Open" state. This means that it hasn't been marked as "Accepted" > > by an existing contributor, signifying that someone thinks it's an > > issue worth pursuing. In this case, the first step is to begin a > > discussion on the issue by commenting on JIRA, and perhaps drawing > > attention to it via this mailing list, to see how the community thinks > we should proceed. > > > > I would recommend that you first assign MESOS-4370 to yourself (this > > will require contributor permissions on JIRA, which can be secured > > with a short email to this mailing list requesting them). You already > > did a good job of summarizing your approach in the description of your > > review request, which you also posted on JIRA, so hopefully this > > thread will draw the attention of some interested parties who can > > provide some feedback, as well as a committer who might have some time > > to shepherd the ticket for you :-) > > > > Cheers, and welcome! > > Greg > > > > > > On Tue, Feb 2, 2016 at 11:18 AM, Hegner, Travis > > <[email protected]> > > wrote: > > > >> Hello All, > >> > >> I am requesting a review of a patch to MESOS-4370. Here are all of > >> the pertinent links: > >> > >> https://issues.apache.org/jira/browse/MESOS-4370 > >> https://reviews.apache.org/r/43093/ > >> https://github.com/apache/mesos/pull/90 > >> > >> I have tagged Benjamin Hindman as a reviewer already on the review > >> board as he was listed as the maintainer of the Docker containerizer. > >> I have not had any previous contact with him. My apologies if this is > bad etiquette. > >> > >> The patch eliminates the use of the deprecated > "NetworkSettings.IPAddress" > >> field in the docker inspect output, and replaces it with using the > >> appropriate "NetworkSettings.Networks.<name>.IPAddress" field, where > >> <name> is the name of the network as it was passed to the last "--net > >> <name>" on the docker run command. The network name is available and > >> queried from the "HostConfig.NetworkMode" field in the inspect output. > >> > >> Thanks, > >> Travis Hegner > >> > -- Best Regards, Haosdent Huang
