+1 for consistency, +1 for executables. I do enough finger yoga while using emacs!
running `find /usr/local/bin -name "*-*" | wc -l` returned 142 while `find /usr/local/bin -name "*_*" | wc -l` was only 17. So I feel using hyphen for executables is more standard. > On 11 Feb 2016, at 14:58, Michael Park <mp...@apache.org> wrote: > > +1 for consistency, +1 for hyphens for executables. > > On 11 February 2016 at 14:25, Kevin Klues <klue...@gmail.com> wrote: > >> I typically think of files having dashes as binaries or scripts that >> are runnable, whereas files with underscores are meant as source or >> otherwise supplementary to the binary produced (e.g. a supplementary >> python library that the main python program imports). I'm not sure >> where I inherited this convention from, but it's always been the way >> I've done things. >> >> As far as our code base goes, we seem to use this convention as well >> with our mesos-master.sh. mesos-slave.sh, etc. binaries. >> >> On Thu, Feb 11, 2016 at 2:17 PM, Vinod Kone <vinodk...@apache.org> wrote: >>> Why hyphens? Most of the files in our repo use underscores. I would like >> us >>> to be consistent on how we name files in the repo. >>> >>> On Thu, Feb 11, 2016 at 1:40 PM, Kevin Klues <klue...@gmail.com> wrote: >>> >>>> I prefer hyphens as well.... >>>> >>>> On Thu, Feb 11, 2016 at 1:28 PM, Jojy Varghese <j...@mesosphere.io> >> wrote: >>>>> hyphen++. Is google friendly apparently. Also less keys to press :) >>>>> >>>>> -Jojy >>>>> >>>>> >>>>> >>>>>> On Feb 11, 2016, at 12:43 PM, Greg Mann <g...@mesosphere.io> wrote: >>>>>> >>>>>> +1 >>>>>> >>>>>> On Thu, Feb 11, 2016 at 11:41 AM, Vinod Kone <vinodk...@apache.org> >>>> wrote: >>>>>> >>>>>>> Some the scripts in the "support" directory have dashes ("-") in >> their >>>>>>> names (e.g., apply-review.sh, apply-reviews.py), whereas some have >>>>>>> underscores ("_") (e.g., docker_build.sh, mesos_split.py). >>>>>>> >>>>>>> This is really confusing and we should stick with one style. I >> propose >>>> to >>>>>>> change all them to use underscores. I will make sure the CI jobs are >>>>>>> updated accordingly. >>>>>>> >>>>>>> Any objections? >>>>>>> >>>>>>> Thanks, >>>>>>> Vinod >>>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> ~Kevin >>>> >> >> >> >> -- >> ~Kevin >>