Thanks for the feedback, guys! I think we all agree that using libcurl is the ideal solution. I've already created a ticket for this: https://issues.apache.org/jira/browse/MESOS-4853
Currently, only docker/appc image puller is using 'curl' directly. I guess it's not a problem on Windows yet. Based on the discussion, I won't add a 'curl' dependency to Mesos. Instead, I'll mention the 'curl' dependency in the doc of container image support for now. Hopefully, we can remove that dependency soon when MESOS-4853 is addressed. Thanks, - Jie On Fri, Mar 4, 2016 at 12:00 PM, Alexander Rojas <[email protected]> wrote: > I also have my doubts about this idea. Given that we support some legacy > systems and the user interface tends to be less stable than an API (though > comparing the flags between curl 7.38.0 in Debian 8 and curl 7.19.7 in > CentOS 6.7, I don’t see a lot of differences in the important ones). > > So I guess what I am trying to say is, if we go this route, let’s make > sure it is fully compatible across versions and the behavior is uniform. > > > > On 03 Mar 2016, at 18:39, Alex Clemmer <[email protected]> > wrote: > > > > Looks like the relevant review is this one: > > https://reviews.apache.org/r/40418/diff/3#4 > > > > I _suspect_ this will work with Windows, but am not positive. > > Optimistically, it's not clear to me whether it makes sense to add it > > as a dependency, because I don't know how to get its location reliably > > on Windows. Because Windows has no package manager, we actually rope > > it in the libcurl dependency from CMake, at build time. Seems like the > > thing to do might be to just build the exe as well and dispatch to > > that but this will require some modifications to this code. > > > > On Thu, Mar 3, 2016 at 5:46 PM, Guangya Liu <[email protected]> wrote: > >> libcurl can automatically picks up certain environment variables and > >> adjusts its settings accordingly, so libcurl support enabling http_proxy > >> and https_proxy by default, this is important feature for someone who > want > >> to use a proxy to connect internet. One example is that I cannot get > google > >> docker images but need a proxy set in China. > >> > >> If we depend on "curl" (I saw that we already finished the this in > >> MESOS-2840) when using fetcher, I think that we may also need to enable > >> slave to pass a proxy to fetch curl to enable someone can pull google > >> docker images under a firewall. Does it make sense file a JIRA to > support > >> http proxy? > >> > >> Thanks, > >> > >> Guangya > >> > >> On Fri, Mar 4, 2016 at 9:39 AM, Klaus Ma <[email protected]> > wrote: > >> > >>> +1 to add 'curl' dependency firstly. > >>> > >>> ---- > >>> Da (Klaus), Ma (马达) | PMP® | Advisory Software Engineer > >>> Platform OpenSource Technology, STG, IBM GCG > >>> +86-10-8245 4084 | [email protected] | http://k82.me > >>> > >>> On Fri, Mar 4, 2016 at 5:04 AM, Jojy Varghese <[email protected]> > wrote: > >>> > >>>> +1 > >>>> > >>>> On Thu, Mar 3, 2016 at 12:52 PM Jake Farrell <[email protected]> > >>> wrote: > >>>> > >>>>> +1 > >>>>> > >>>>> -Jake > >>>>> > >>>>> On Thu, Mar 3, 2016 at 12:10 PM, Jie Yu <[email protected]> wrote: > >>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I am proposing making 'curl' a prerequisite when installing Mesos. > >>>>>> Currently, we require 'libcurl' being present when installing Mesos > ( > >>>>>> http://mesos.apache.org/gettingstarted/). However, we found that it > >>>> does > >>>>>> not compose well with our asynchronous runtime environment (i.e., > >>> it'll > >>>>>> block the current worker thread). > >>>>>> > >>>>>> Recent work on URI fetcher > >>>>>> <https://issues.apache.org/jira/browse/MESOS-3918> uses 'curl' > >>>> directly, > >>>>>> instead of using 'libcurl' to fetch artifacts, because it composes > >>> well > >>>>>> with our async runtime env. 'curl' is installed by default in most > >>>>> systems > >>>>>> (e.g., OSX, centos, RHEL). > >>>>>> > >>>>>> So I am proposing adding 'curl' to our prerequisite list. Let me > know > >>>> if > >>>>>> you have any concern on this. I'll update the Getting Started doc if > >>>> you > >>>>>> are OK with this change. > >>>>>> > >>>>>> Thanks, > >>>>>> - Jie > >>>>>> > >>>>> > >>>> > >>> > > > > > > > > -- > > Alex > > > > Theory is the first term in the Taylor series of practice. -- Thomas M > > Cover (1992) > >
