Sure, that's fine with me. Since the fix for the flaky test was a flaw in the test itself there shouldn't be any issues.
Thanks for double checking. Especially since my vote was non-binding. Kevin On Mon, Mar 7, 2016 at 7:33 PM, Michael Park <[email protected]> wrote: > Kevin, > > Sorry for missing your flaky test patch. It seems like we added the 0.27.2 > to the backports list after you had indicated that 0.24.2, 0.25.1, and > 0.26.1 > needs to include the patch. We should have asked whether this needs to > be included in 0.27.2 as well. I think we missed it because there were many > patches that needed to be included in 0.24.2, 0.25.1 and 0.26.1 but not > 0.27.2 > since they had made it into 0.27.0 or 0.27.1. > > Having said that, I'm inclined to agree with Joris and proceed since it > doesn't > have much of an impact in terms of the resulting binary, for example. > > Could you confirm or deny whether you're ok with this? > > Thanks, > > MPark > > On 4 March 2016 at 15:51, Joris Van Remoortere > <[email protected]> wrote: >> >> +1 (binding) >> Greg's upgrade scripts & CI results >> >> The missing commit is for a flaky test which doesn't influence the >> production binaries. >> Unless we need to cut another RC for a bug, I suggest we move ahead. >> >> On Wed, Mar 2, 2016 at 10:36 AM, Jörg Schad <[email protected]> wrote: >> >> > Except the missing fix for Mesos-4518, if we consider cutting a rc2 >> > for that, maybe we could include the fix for MESOS-4677 as well (see >> > failing ROOT_CGROUPS_Pids_and_Tids test below). >> > +1 (non-binding) >> > >> > All the failing tests I encountered seem to be known. >> > >> > Centos 7 >> > * LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids (fixed with >> > MESOS-4677 for 0.28 ) >> > * LinuxFilesystemIsolatorTest.ROOT_MultipleContainers (open ticket >> > MESOS-4423) >> > >> > Centos 7 - SSL >> > All green >> > >> > Centos 6 (+/- SSL) >> > * MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery (reopened >> > MESOS-4047) >> > >> > Debian 8 (+/- SSL) >> > * DockerContainerizerTest.ROOT_DOCKER_Kill (seems the same issue as >> > MESOS-3937) >> > >> > Ubuntu 15 (+/- SSL) >> > Green >> > >> > Ubuntu 14 (+/- SSL) >> > Green >> > >> > Ubuntu 12 (+/- SSL) >> > Green >> > >> > On Tue, Mar 1, 2016 at 10:18 PM, Kevin Klues <[email protected]> wrote: >> > > -1 (non-binding) >> > > >> > > This release >> > > candidate >> > > should have included the backport to re >> > > s >> > > olv >> > > e >> > > MESOS-4518 <https://issues.apache.org/jira/browse/MESOS-4518>. >> > > All of the other release candidates that came out as backports >> > > recently >> > > have included this, but somehow this one was overlooked. >> > > >> > > >> > > >> > > >> > > On Tue, Mar 1, 2016 at 4:35 PM, Greg Mann <[email protected]> wrote: >> > > >> > >> I was able to successfully test a simple upgrade scenario between >> > >> 0.26.1-rc1 and 0.27.2-rc1 using Niklas's upgrade testing script, >> > >> which >> > I've >> > >> modified slightly and reposted here: >> > https://reviews.apache.org/r/44229/ >> > >> >> > >> On Tue, Mar 1, 2016 at 2:22 PM, Kevin Klues <[email protected]> >> > >> wrote: >> > >> >> > >> > The others all seem to have them though: >> > >> > >> > >> > >> > >> > >> > >> >> > >> > https://github.com/apache/mesos/commits/0.26.1-rc1/src/tests/master_tests.cpp >> > >> > >> > >> > >> > >> >> > >> > https://github.com/apache/mesos/commits/0.25.1-rc1/src/tests/master_tests.cpp >> > >> > >> > >> > >> > >> >> > >> > https://github.com/apache/mesos/commits/0.24.2-rc1/src/tests/master_tests.cpp >> > >> > >> > >> > Just not: >> > >> > >> > >> > >> > >> >> > >> > https://github.com/apache/mesos/commits/0.27.2-rc1/src/tests/master_tests.cpp >> > >> > >> > >> > On Tue, Mar 1, 2016 at 2:17 PM, Kevin Klues <[email protected]> >> > wrote: >> > >> > > Looks like this rc is missing this commit: >> > >> > > >> > >> > > >> > >> > >> > >> >> > >> > https://github.com/apache/mesos/commit/d3108d776b6f7121e37176eda686ecc7245be4cd >> > >> > > >> > >> > > On Tue, Mar 1, 2016 at 2:08 PM, Joris Van Remoortere >> > >> > > <[email protected]> wrote: >> > >> > >> @Michael Browning: >> > >> > >>> >> > >> > >>> MasterTest.MaxCompletedTasksPerFrameworkFlag [flaky, tracked in >> > >> > >>> MESOS-4518] >> > >> > >> >> > >> > >> This is supposed to be fixed in this release. It is concerning >> > >> > >> that >> > >> this >> > >> > >> came up. >> > >> > >> Can you verify this and provide logs to Kevin Klues? >> > >> > >> >> > >> > >> >> > >> > >> — >> > >> > >> Joris Van Remoortere >> > >> > >> Mesosphere >> > >> > >> >> > >> > >> On Tue, Mar 1, 2016 at 2:00 PM, Michael Browning < >> > >> > [email protected]> >> > >> > >> wrote: >> > >> > >>> >> > >> > >>> +1 (non-binding) >> > >> > >>> >> > >> > >>> Fedora 23: `make check` non-root OK >> > >> > >>> OS X: `make check` non-root OK >> > >> > >>> Ubuntu 14.04: `make check` non-root, three failures: >> > >> > >>> ContainerLoggerTest.DefaultToSandbox [flaky, tracked in >> > MESOS-4615] >> > >> > >>> MasterQuotaTest.AvailableResourcesAfterRescinding [flaky, >> > >> > >>> tracked >> > in >> > >> > >>> MESOS-4542] >> > >> > >>> MasterTest.MaxCompletedTasksPerFrameworkFlag [flaky, tracked in >> > >> > >>> MESOS-4518] >> > >> > >>> >> > >> > >>> On Mon, Feb 29, 2016 at 10:40 PM, Greg Mann >> > >> > >>> <[email protected]> >> > >> > wrote: >> > >> > >>> >> > >> > >>> > +1 (non-binding) >> > >> > >>> > >> > >> > >>> > `sudo make check` on Ubuntu 14.04 using gcc, with libevent >> > >> > >>> > and >> > SSL >> > >> > >>> > enabled. >> > >> > >>> > >> > >> > >>> > All tests pass except >> > >> > MemoryPressureMesosTest.CGROUPS_ROOT_Statistics, >> > >> > >>> > which seems to be due to the issue found here: >> > >> > >>> > https://issues.apache.org/jira/browse/MESOS-4053 >> > >> > >>> > >> > >> > >>> > >> > >> > >>> > On Mon, Feb 29, 2016 at 2:17 PM, Michael Park >> > >> > >>> > <[email protected] >> > > >> > >> > wrote: >> > >> > >>> > >> > >> > >>> > > Vinod, we've only committed the CHANGELOGs to the specific >> > tags. >> > >> I >> > >> > >>> > > didn't >> > >> > >>> > > realize that I should commit those to master as well, but >> > >> > >>> > > it >> > >> makes >> > >> > >>> > > total >> > >> > >>> > > sense to do so. I'll do that. Thanks. >> > >> > >>> > > >> > >> > >>> > > On 29 February 2016 at 13:50, Vinod Kone < >> > [email protected]> >> > >> > wrote: >> > >> > >>> > > >> > >> > >>> > >> I don't see CHANGELOGs for these versions on the master >> > branch? >> > >> > >>> > >> >> > >> > >>> > >> On Mon, Feb 29, 2016 at 1:39 PM, Neil Conway < >> > >> > [email protected]> >> > >> > >>> > >> wrote: >> > >> > >>> > >> >> > >> > >>> > >> > As described (briefly) in the release emails, 0.27.2, >> > 0.26.1, >> > >> > >>> > >> > 0.25.1, >> > >> > >>> > >> > and 0.24.2 contains a new feature: "reliable floating >> > >> > >>> > >> > point >> > >> for >> > >> > >>> > >> > scalar >> > >> > >>> > >> > resources" (MESOS-4687). >> > >> > >>> > >> > >> > >> > >>> > >> > To elaborate on that slightly, Mesos now only supports >> > scalar >> > >> > >>> > >> > resource >> > >> > >>> > >> > values with three decimal digits of precision (e.g., >> > reserving >> > >> > >>> > >> > "5.001 >> > >> > >>> > >> > CPUs" for a task). As a result of this change, >> > >> > >>> > >> > frameworks >> > that >> > >> > do >> > >> > >>> > >> > their own resource math may see slightly different >> > >> > >>> > >> > results; >> > >> > >>> > >> > furthermore, if any frameworks were trying to manage >> > extremely >> > >> > >>> > >> > fine-grained resource values (> 3 decimal digits of >> > >> precision), >> > >> > >>> > >> > that >> > >> > >>> > >> > will no longer be supported. >> > >> > >>> > >> > >> > >> > >>> > >> > For more information, please see: >> > >> > >>> > >> > >> > >> > >>> > >> > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://mail-archives.apache.org/mod_mbox/mesos-user/201602.mbox/%3CCAOW5sYZJn5caBOwZyPV008JgL1F2FYFxL_bM5CtYA2PF2OG7Bw%40mail.gmail.com%3E >> > >> > >>> > >> > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://docs.google.com/document/d/14qLxjZsfIpfynbx0USLJR0GELSq8hdZJUWw6kaY_DXc/edit?usp=sharing >> > >> > >>> > >> > https://issues.apache.org/jira/browse/MESOS-4687 >> > >> > >>> > >> > >> > >> > >>> > >> > Neil >> > >> > >>> > >> > >> > >> > >>> > >> > >> > >> > >>> > >> > On Fri, Feb 26, 2016 at 8:54 PM, Michael Park < >> > >> > [email protected]> >> > >> > >>> > >> wrote: >> > >> > >>> > >> > > Hi all, >> > >> > >>> > >> > > >> > >> > >>> > >> > > Please vote on releasing the following candidate as >> > Apache >> > >> > Mesos >> > >> > >>> > >> 0.27.2. >> > >> > >>> > >> > > >> > >> > >>> > >> > > >> > >> > >>> > >> > > 0.27.2 includes the following: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > -------------------------------------------------------------------------------- >> > >> > >>> > >> > > >> > >> > >>> > >> > > MESOS-4693 - Variable shadowing in >> > >> > >>> > >> HookManager::slavePreLaunchDockerHook. >> > >> > >>> > >> > > MESOS-4711 - Race condition in libevent poll >> > implementation >> > >> > >>> > >> > > causes >> > >> > >>> > >> crash. >> > >> > >>> > >> > > MESOS-4754 - The "executors" field is exposed under a >> > >> > backwards >> > >> > >>> > >> > incompatible >> > >> > >>> > >> > > schema. >> > >> > >>> > >> > > MESOS-4687 - Implement reliable floating point for >> > >> > >>> > >> > > scalar >> > >> > >>> > >> > > resources. >> > >> > >>> > >> > > >> > >> > >>> > >> > > >> > >> > >>> > >> > > The CHANGELOG for the release is available at: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.27.2-rc1 >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > -------------------------------------------------------------------------------- >> > >> > >>> > >> > > >> > >> > >>> > >> > > The candidate for Mesos 0.27.2 release is available >> > >> > >>> > >> > > at: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://dist.apache.org/repos/dist/dev/mesos/0.27.2-rc1/mesos-0.27.2.tar.gz >> > >> > >>> > >> > > >> > >> > >>> > >> > > The tag to be voted on is 0.27.2-rc1: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.27.2-rc1 >> > >> > >>> > >> > > >> > >> > >>> > >> > > The MD5 checksum of the tarball can be found at: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://dist.apache.org/repos/dist/dev/mesos/0.27.2-rc1/mesos-0.27.2.tar.gz.md5 >> > >> > >>> > >> > > >> > >> > >>> > >> > > The signature of the tarball can be found at: >> > >> > >>> > >> > > >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > >> > >> > >>> > >> > >> > >> > >> >> > >> > https://dist.apache.org/repos/dist/dev/mesos/0.27.2-rc1/mesos-0.27.2.tar.gz.asc >> > >> > >>> > >> > > >> > >> > >>> > >> > > The PGP key used to sign the release is here: >> > >> > >>> > >> > > https://dist.apache.org/repos/dist/release/mesos/KEYS >> > >> > >>> > >> > > >> > >> > >>> > >> > > The JAR is up in Maven in a staging repository here: >> > >> > >>> > >> > > >> > >> > >>> > >> >> > >> > >>> > >> >> > >> > >> > https://repository.apache.org/content/repositories/orgapachemesos-1104 >> > >> > >>> > >> > > >> > >> > >>> > >> > > Please vote on releasing this package as Apache Mesos >> > >> 0.27.2! >> > >> > >>> > >> > > >> > >> > >>> > >> > > The vote is open until Wed Mar 2 23:59:59 PST 2016 and >> > >> passes >> > >> > if >> > >> > >>> > >> > > a >> > >> > >>> > >> > majority >> > >> > >>> > >> > > of at least 3 +1 PMC votes are cast. >> > >> > >>> > >> > > >> > >> > >>> > >> > > [ ] +1 Release this package as Apache Mesos 0.27.2 >> > >> > >>> > >> > > [ ] -1 Do not release this package because ... >> > >> > >>> > >> > > >> > >> > >>> > >> > > Thanks, >> > >> > >>> > >> > > >> > >> > >>> > >> > > MPark, Joris, Kapil >> > >> > >>> > >> > >> > >> > >>> > >> >> > >> > >>> > > >> > >> > >>> > > >> > >> > >>> > >> > >> > >> >> > >> > >> >> > >> > > >> > >> > > >> > >> > > >> > >> > > -- >> > >> > > ~Kevin >> > >> > >> > >> > >> > >> > >> > >> > -- >> > >> > ~Kevin >> > >> > >> > >> >> > > >> > > >> > > >> > > -- >> > > ~Kevin >> > > > -- ~Kevin
