Yes it has existed for a long time but has only been discovered recently. The way this was discovered was that garbage collection of user sandboxes fails, which can result in the disk eventually filling up. This occurs when there are special files in the sandbox (e.g. socket file).
IMO it's a critical issue to fix. On Sat, Mar 19, 2016 at 6:39 AM, Michael Park <[email protected]> wrote: > Ben, > > Do I understand correctly that this is not a regression, but a fix > important enough for us to backport? > I'm curious as to what makes it significant. Could you elaborate a little > as to what the consequences are? > > Thanks! > > MPark > > On 18 March 2016 at 16:20, Benjamin Mahler <[email protected]> wrote: > >> These are be captured under: >> https://issues.apache.org/jira/browse/MESOS-4979 >> >> On Thu, Mar 17, 2016 at 5:04 PM, Benjamin Mahler <[email protected]> >> wrote: >> >>> Thanks for the hard work! Do we need to backport the rmdir fixes on the >>> outstanding release candidates? >>> >>> commit 5278e5cc50544ed7af28b15a1acd2b2e96a15a47 >>> Author: Jojy Varghese <[email protected]> >>> Date: Tue Mar 15 17:12:01 2016 -0700 >>> >>> Added support for FTS_SLNONE in rmdir. >>> >>> Review: https://reviews.apache.org/r/44874/ >>> >>> commit fbe1f37f65fd9f1d4f2c30a3cfd7a50df92ccc2c >>> Author: Alex Clemmer <[email protected]> >>> Date: Tue Mar 1 23:29:21 2016 -0800 >>> >>> Stout:[1/2] Fixed error reporting bug in `os::rmdir`. >>> >>> Review: https://reviews.apache.org/r/43907/ >>> >>> commit f8b7ac28b1a918864a06b3f99f45b0257c7b6f68 >>> Author: Jojy Varghese <[email protected]> >>> Date: Tue Mar 1 14:32:13 2016 -0800 >>> >>> Added FS_DEFAULT case in rmdir. >>> >>> We currently dont handle special files like device files in rmdir. >>> This >>> change adds FS_DEFAULT as one of the cases where we try to unlink a >>> file. Reference: http://man7.org/linux/man-pages/man3/fts.3.html >>> >>> Review: https://reviews.apache.org/r/44230/ >>> >>> On Wed, Mar 16, 2016 at 8:21 PM, Vinod Kone <[email protected]> >>> wrote: >>> >>>> +1 (binding) >>>> >>>> Tested on ASF CI. >>>> >>>> On Sun, Mar 13, 2016 at 4:33 PM, Michael Park <[email protected]> wrote: >>>> >>>> > +1 (binding) >>>> > >>>> > Internal CI results with the corresponding JIRA tickets for the failed >>>> > tests: >>>> > >>>> > CentOS 6 (non-SSL): >>>> > - MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward >>>> > (MESOS-3049 <https://issues.apache.org/jira/browse/MESOS-3049>) >>>> > - PerfEventIsolatorTest.ROOT_CGROUPS_Sample >>>> > (MESOS-4039 <https://issues.apache.org/jira/browse/MESOS-4039>) >>>> > - UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup >>>> > (MESOS-4035 <https://issues.apache.org/jira/browse/MESOS-4035>) >>>> > - CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf >>>> > (MESOS-3215 <https://issues.apache.org/jira/browse/MESOS-3215>) >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_Statistics >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery >>>> > (MESOS-4047 <https://issues.apache.org/jira/browse/MESOS-4047>, >>>> > MESOS-4053 <https://issues.apache.org/jira/browse/MESOS-4053>) >>>> > >>>> > CentOS 6 (SSL): >>>> > - MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward >>>> > (MESOS-3049 <https://issues.apache.org/jira/browse/MESOS-3049>) >>>> > - PerfEventIsolatorTest.ROOT_CGROUPS_Sample >>>> > (MESOS-4039 <https://issues.apache.org/jira/browse/MESOS-4039>) >>>> > - UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup >>>> > (MESOS-4035 <https://issues.apache.org/jira/browse/MESOS-4035>) >>>> > - CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf >>>> > (MESOS-3215 <https://issues.apache.org/jira/browse/MESOS-3215>) >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_Statistics >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery >>>> > (MESOS-4047 <https://issues.apache.org/jira/browse/MESOS-4047>, >>>> > MESOS-4053 <https://issues.apache.org/jira/browse/MESOS-4053>) >>>> > >>>> > CentOS 7 (non-SSL): >>>> > - LimitedCpuIsolatorTest.ROOT_CGROUPS_Pids_and_Tids >>>> > (MESOS-4677 <https://issues.apache.org/jira/browse/MESOS-4677>) >>>> > - PerfEventIsolatorTest.ROOT_CGROUPS_Sample >>>> > (MESOS-4039 <https://issues.apache.org/jira/browse/MESOS-4039>) >>>> > - CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf >>>> > (MESOS-3215 <https://issues.apache.org/jira/browse/MESOS-3215>) >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_Statistics >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery >>>> > (MESOS-4047 <https://issues.apache.org/jira/browse/MESOS-4047>, >>>> > MESOS-4053 <https://issues.apache.org/jira/browse/MESOS-4053>) >>>> > >>>> > CentOS 7 (SSL): >>>> > - FetcherCacheTest.RemoveLRUCacheEntries >>>> > (MESOS-4156 <https://issues.apache.org/jira/browse/MESOS-4156>) >>>> > - PerfEventIsolatorTest.ROOT_CGROUPS_Sample >>>> > (MESOS-4039 <https://issues.apache.org/jira/browse/MESOS-4039>) >>>> > - CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf >>>> > (MESOS-3215 <https://issues.apache.org/jira/browse/MESOS-3215>) >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_Statistics >>>> > - MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery >>>> > (MESOS-4047 <https://issues.apache.org/jira/browse/MESOS-4047>, >>>> > MESOS-4053 <https://issues.apache.org/jira/browse/MESOS-4053>) >>>> > >>>> > Debian 8 (non-SSL): Success! >>>> > Debian 8 (SSL): Failed with MESOS-2017 >>>> > <https://issues.apache.org/jira/browse/MESOS-2017> >>>> > >>>> > Ubuntu 12 (non-SSL): >>>> > Ubuntu 12 (SSL): >>>> > Ubuntu 14 (non-SSL): >>>> > Ubuntu 14 (SSL): >>>> > - UserCgroupIsolatorTest/0.ROOT_CGROUPS_UserCgroup >>>> > - UserCgroupIsolatorTest/1.ROOT_CGROUPS_UserCgroup >>>> > (MESOS-4035 <https://issues.apache.org/jira/browse/MESOS-4035>) >>>> > >>>> > Ubuntu 15 (non-SSL): Success! >>>> > Ubuntu 15 (SSL): Success! >>>> > >>>> > On 13 March 2016 at 18:43, Michael Park <[email protected]> wrote: >>>> > >>>> > > While the vote for this release was open until Fri Mar 11 23:59:59 >>>> EST >>>> > > 2016, >>>> > > I'm going to give it another 3 days since there has not been any -1 >>>> > votes. >>>> > > >>>> > > The vote is extended until Wed Mar 16 23:59:59 EST 2016. >>>> > > >>>> > > On 10 March 2016 at 12:40, Michael Park <[email protected]> wrote: >>>> > > >>>> > >> Thanks Greg! >>>> > >> >>>> > >> On 10 March 2016 at 12:32, Greg Mann <[email protected]> wrote: >>>> > >> >>>> > >>> +1 (non-binding) >>>> > >>> >>>> > >>> Ran `sudo make check` on CentOS 7, using gcc with libevent and SSL >>>> > >>> enabled. All tests pass. >>>> > >>> >>>> > >>> I was also able to successfully test a simple upgrade scenario >>>> from >>>> > >>> 0.25.1-rc2 to 0.26.1-rc2 using the script found here: >>>> > >>> https://reviews.apache.org/r/44229/ >>>> > >>> >>>> > >>> Cheers, >>>> > >>> Greg >>>> > >>> >>>> > >>> >>>> > >>> On Tue, Mar 8, 2016 at 7:48 PM, Michael Park <[email protected]> >>>> wrote: >>>> > >>> >>>> > >>>> Hi all, >>>> > >>>> >>>> > >>>> Please vote on releasing the following candidate as Apache Mesos >>>> > 0.26.1. >>>> > >>>> >>>> > >>>> >>>> > >>>> 0.26.1 includes the following: >>>> > >>>> >>>> > >>>> >>>> > >>>> -------------------------------------------------------------------------------- >>>> > >>>> >>>> > >>>> The only diff with RC1 is the following: Fix CGROUPS_ROOT_* >>>> tests on >>>> > >>>> systemd platforms. >>>> > >>>> < >>>> > >>>> https://github.com/apache/mesos/commit/a896cda4aa8bb9c9bbfba20dda4b68df8dbdf569 >>>> > > >>>> > >>>> This patch is necessary in order to make the `systemd` >>>> integration >>>> > work >>>> > >>>> correctly. >>>> > >>>> It was part of MESOS-4636 >>>> > >>>> <https://issues.apache.org/jira/browse/MESOS-4636> but was >>>> > >>>> accidentally left out during the cherry-pick process. >>>> > >>>> >>>> > >>>> * Improvements >>>> > >>>> - `/state` endpoint performance >>>> > >>>> - `systemd` integration >>>> > >>>> - GLOG performance >>>> > >>>> - Configurable task/framework history >>>> > >>>> - Offer filter timeout fix for backlogged allocator >>>> > >>>> >>>> > >>>> * Bugs >>>> > >>>> - SSL >>>> > >>>> - Libevent >>>> > >>>> - Fixed point resources math >>>> > >>>> - HDFS >>>> > >>>> - Agent upgrade compatibility >>>> > >>>> >>>> > >>>> The CHANGELOG for the release is available at: >>>> > >>>> >>>> > >>>> >>>> > >>>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=blob_plain;f=CHANGELOG;hb=0.26.1-rc2 >>>> > >>>> >>>> > >>>> >>>> > >>>> -------------------------------------------------------------------------------- >>>> > >>>> >>>> > >>>> The candidate for Mesos 0.26.1 release is available at: >>>> > >>>> >>>> > >>>> >>>> > >>>> https://dist.apache.org/repos/dist/dev/mesos/0.26.1-rc2/mesos-0.26.1.tar.gz >>>> > >>>> >>>> > >>>> The tag to be voted on is 0.26.1-rc2: >>>> > >>>> >>>> > >>>> >>>> > >>>> https://git-wip-us.apache.org/repos/asf?p=mesos.git;a=commit;h=0.26.1-rc2 >>>> > >>>> >>>> > >>>> The MD5 checksum of the tarball can be found at: >>>> > >>>> >>>> > >>>> >>>> > >>>> https://dist.apache.org/repos/dist/dev/mesos/0.26.1-rc2/mesos-0.26.1.tar.gz.md5 >>>> > >>>> >>>> > >>>> The signature of the tarball can be found at: >>>> > >>>> >>>> > >>>> >>>> > >>>> https://dist.apache.org/repos/dist/dev/mesos/0.26.1-rc2/mesos-0.26.1.tar.gz.asc >>>> > >>>> >>>> > >>>> The PGP key used to sign the release is here: >>>> > >>>> https://dist.apache.org/repos/dist/release/mesos/KEYS >>>> > >>>> >>>> > >>>> The JAR is up in Maven in a staging repository here: >>>> > >>>> >>>> > >>>> https://repository.apache.org/content/repositories/orgapachemesos-1118 >>>> > >>>> >>>> > >>>> Please vote on releasing this package as Apache Mesos 0.26.1! >>>> > >>>> >>>> > >>>> The vote is open until Fri Mar 11 23:59:59 EST 2016 and passes >>>> if a >>>> > >>>> majority of at least 3 +1 PMC votes are cast. >>>> > >>>> >>>> > >>>> [ ] +1 Release this package as Apache Mesos 0.26.1 >>>> > >>>> [ ] -1 Do not release this package because ... >>>> > >>>> >>>> > >>>> Thanks, >>>> > >>>> >>>> > >>>> MPark >>>> > >>>> >>>> > >>> >>>> > >>> >>>> > >> >>>> > > >>>> > >>>> >>> >>> >> >
