Thanks, Kapil. I've added you as reviewer. On Wed, Mar 23, 2016 at 11:45 AM, Kapil Arya <[email protected]> wrote:
> Anurag, Yan, > > I can also help in reviewing this stuff. If Yan, has cycles to shepherd it, > great, otherwise, I can shepherd it too. > > Best, > Kapil > > On Wed, Mar 23, 2016 at 2:38 PM, Anurag Singh < > [email protected]> wrote: > > > Yan, would you like me to add you as the reviewer on the ReviewBoard > > changes? I'm assuming that you will be the shepherd. Please let me know > if > > that isn't confirmed yet. > > > > On Mon, Mar 21, 2016 at 1:08 PM, Benjamin Mahler <[email protected]> > > wrote: > > > > > +Yan > > > > > > On Mon, Mar 21, 2016 at 10:28 AM, Anurag Singh < > > > [email protected]> wrote: > > > > > > > Joseph's suggestion is that since Ben Hindman may not have enough > time > > to > > > > shepherd this issue, we should seek another one. Would anyone here be > > > able > > > > to shepherd https://issues.apache.org/jira/browse/MESOS-4610? > > > > > > > > > > > > On Tue, Mar 15, 2016 at 1:13 PM, Anurag Singh < > > > > [email protected]> wrote: > > > > > > > > > As of now, we've got Ben Hindman as the designated shepherd. Joesph > > Wu > > > > has > > > > > been helping us with the reviews and suggesting changes. > > > > > > > > > > On Tue, Mar 15, 2016 at 1:09 PM, Vinod Kone <[email protected]> > > > > wrote: > > > > > > > > > >> This is great to hear! @YanXu is this something you might be able > to > > > > >> shepherd? > > > > >> > > > > >> On Tue, Mar 15, 2016 at 1:03 PM, Anurag Singh < > > > > >> [email protected]> wrote: > > > > >> > > > > >> > Hi, > > > > >> > > > > > >> > We're inviting user and developer comments on a series of > changes > > we > > > > >> have > > > > >> > been working on that would modularize MasterContender and > > > > >> MasterDetectors. > > > > >> > The goal is to allow the use of detector and contender > > > implementations > > > > >> > other than the ones that are part of Mesos source (Standalone > and > > > > >> > Zookeeper). So if one would like to use a custom leader election > > > > >> mechanism > > > > >> > (e.g. one that relies on etcd, consul, etc.), it will be > possible > > to > > > > >> load > > > > >> > the implementation from a shared library. In practice, it > > translates > > > > to > > > > >> > using the following command line options: > > > > >> > > > > > >> > For the mesos master: > > > > >> > > > > > >> > --master_contender: The value of this command line option is the > > > name > > > > >> of a > > > > >> > symbol (defined in a module and referenced in the value of the > > > > --modules > > > > >> > flag). The symbol refers to an object of type > > > Module<MasterContender>. > > > > >> For > > > > >> > an example, please see the test_contender_module.cpp file in > > > > >> > https://reviews.apache.org/r/44289/. > > > > >> > > > > > >> > For the mesos master and slave: > > > > >> > > > > > >> > --master_detector: The value of this command line option is the > > > name > > > > >> of a > > > > >> > symbol (defined in a module and referenced in the value of the > > > > --modules > > > > >> > flag). The symbol refers to an object of type > > > Module<MasterDetector>. > > > > >> For > > > > >> > an example, please see the test_detector_module.cpp file in > > > > >> > https://reviews.apache.org/r/44289/. > > > > >> > > > > > >> > The --modules option, in addition to pointing to the shared > > library > > > > and > > > > >> > symbols, can be used to pass parameters (via the Parameters > class) > > > to > > > > >> the > > > > >> > modules in the form of key-value pairs. > > > > >> > > > > > >> > Also, please note that there is no change in the behavior of the > > > > legacy > > > > >> > --zk and --master options. They will continue to work as before. > > > > >> > > > > > >> > The following changes implement this functionality and have been > > > under > > > > >> > review (thanks to Joseph Wu (Mesosphere) for his input): > > > > >> > > > > > >> > https://reviews.apache.org/r/44287/ > > > > >> > https://reviews.apache.org/r/44288/ > > > > >> > https://reviews.apache.org/r/44543/ > > > > >> > https://reviews.apache.org/r/44544/ > > > > >> > https://reviews.apache.org/r/44545/ > > > > >> > https://reviews.apache.org/r/44546/ > > > > >> > https://reviews.apache.org/r/44547/ > > > > >> > https://reviews.apache.org/r/44289/ > > > > >> > https://reviews.apache.org/r/44669/ > > > > >> > https://reviews.apache.org/r/44670/ > > > > >> > > > > > >> > > > > > > > > > > > > > > > > > > > >
