Re: [1/6] mesos git commit: Fixed a memory leak in the scheduler driver.

[Klaus Ma]

+1

Refer to this doc for the detail of deleting null: 
http://www.cplusplus.com/reference/new/operator%20delete/ 
<http://www.cplusplus.com/reference/new/operator%20delete/>

Thanks
Klaus

> On Mar 30, 2016, at 07:24, Neil Conway <neil.con...@gmail.com> wrote:
> 
> On Tue, Mar 29, 2016 at 7:19 PM,  <vinodk...@apache.org> wrote:
>> --- a/src/sched/sched.cpp
>> +++ b/src/sched/sched.cpp
>> @@ -1808,6 +1808,10 @@ MesosSchedulerDriver::~MesosSchedulerDriver()
>>     delete process;
>>   }
>> 
>> +  if (credential != NULL) {
>> +    delete credential;
>> +  }
> 
> `delete` of a NULL pointer is safe, so I would vote for removing the `if`.
> 
> Neil