I would promote doing the following as well if it doesn't break anything. https://issues.apache.org/jira/browse/MESOS-5186
It would unblock tfmesos (a distributed tensorflow framework on Mesos) from working with an unmodified Mesos. On Wed, Sep 7, 2016 at 2:13 AM Greg Mann <[email protected]> wrote: > AFAICT, this shouldn't break anything, since by omitting the syntax > specification we're effectively setting it to the default, "proto2". As a > quick test, I added `syntax = "proto2";` to the top of mesos.proto, built > Mesos, and then ran some tests - it seems to work fine! > > Greg > > > On Tue, Sep 6, 2016 at 12:50 PM, Zhitao Li <[email protected]> wrote: > > > Hi all, > > > > Does anyone see what could break if we add a line "syntax=proto2" to > every > > public .proto files in Mesos codebase? > > > > Some of our internal project compiles against Mesos and we are manually > > adding this line because we also uses proto3 for internal files, and this > > is necessary for protoc to work correctly. It'll be better if this can be > > added upstream. > > > > This is not really urgent or blocker, just something nice to have. > > > > Thanks! > > > > -- > > Cheers, > > > > Zhitao Li > > >
