Thermos would definitely need a period to adjust where both are supported, as we do make pretty wide usage of $MESOS_DIRECTORY.
On Fri, Oct 7, 2016 at 5:55 PM, Zameer Manji <zma...@apache.org> wrote: > Thanks for clearing that up. > > I've cced Joshua Cohen (who is currently maintaining thermos) to weigh in > here. > > I suspect that deprecating this blindly might break something for tasks > under the Docker Containerizer. > > On Fri, Oct 7, 2016 at 5:33 PM, Jie Yu <yujie....@gmail.com> wrote: > >> https://github.com/apache/mesos/blob/master/docs/versioning.md >> >> "The deprecation period for any given feature will be 6 months. Having a >> set period allows Mesos developers to not indefinitely accrue technical >> debt and allows users time to plan for upgrades." >> >> - Jie >> >> On Fri, Oct 7, 2016 at 5:28 PM, Zameer Manji <zma...@apache.org> wrote: >> >> > Jie, >> > >> > Without commenting on this deprecation, how is this going to work now >> that >> > Mesos is 1.0? >> > >> > What is the definition of "deprecate" being used here? Is it something >> that >> > will be removed in Mesos 2.0? >> > >> > On Fri, Oct 7, 2016 at 4:49 PM, Jie Yu <yujie....@gmail.com> wrote: >> > >> > > Hi, >> > > >> > > Want to initiate a discussion here. Before Mesos containerizer has >> > > container image support (all containers share the same host file >> system), >> > > $MESOS_DIRECTORY env variable is used to let executor know their >> sandbox >> > > location. >> > > >> > > Later, we introduced container image support to Mesos containerizer so >> > that >> > > each container can has its own root filesystem. Due to some historical >> > > reason (thermos), we decided to keep $MESOS_DIRECTORY to be the path >> to >> > the >> > > sandbox on the host filesystem (e.g., `/var/lib/mesos/slaves/...`) >> even >> > if >> > > the container has its own root filesystem. And introduced a new >> > > $MESOS_SANDBOX to point to the sandbox in the container's root >> filesystem >> > > (e.g., `/mnt/mesos/sandbox`). If the container does not have a root >> > > filesystem, $MESOS_DIRECTORY == $MESOS_SANDBOX. >> > > >> > > Now, we plan to deprecate $MESOS_DIRECTORY because it'll be really >> > > confusing to executor writers, and it'll be an error if they try to >> > access >> > > $MESOS_DIRECTORY if their container has a root filesystem defined. >> > > >> > > - Jie >> > > >> > > -- >> > > Zameer Manji >> > > >> > >> >> -- >> Zameer Manji >> >
