Do you have some examples? Thinking through my own experience debugging tests, I tend to only get value out of EXPECT messages when they are providing information that I can't get access to from the line number / actual vs expected printing. (e.g. the value of a variable). If the EXPECT message is simply explaining what the test is doing, then I tend to ignore it and read the test instead, so it would be helpful to discuss some examples to get a better sense. :)
On Sat, Apr 29, 2017 at 10:02 AM, James Peach <jor...@gmail.com> wrote: > Hi all, > > In a couple of reviews, I've been asked to avoid emitting explanatory > messages from the EXPECT() macro. The rationale for this is that tests > usually use comments. However, I think that emitting the reason for a > failed expectation into the test log is pretty helpful and we should do it > more often. > > What do people think about explicitly allowing (or even encouraging) this? > ie. EXPECT(...) << "some explanation goes here" > > J
