Thank you very much, Li, and the rest of the team at Microsoft for pushing this through!
We'll make sure to pay attention to the reviewbot, and we would also really appreciate if you could vote on release candidates to make sure that in case something slips the CI we catch it before cutting the release. Artem. On Tue, May 30, 2017 at 10:58 AM, Li Li <l...@microsoft.com> wrote: > With the joint effort from Mesosphere and Microsoft, the windows build > performance *should* be about equal with Posix/Linux now, ~76% tests are > enabled on the ported windows components, and Mesos container/docker > container tasks are launched successfully e2e. > > We will start helping Mesos windows customers deploy their windows agent > nodes in their test environments, and then productize these features as our > next goals. To be able to do that, we need a stable development > environment. > > Recently, there have been multiple regressions on Windows from build > issues to functionality issues. We have been chasing down these > regressions, fixing them and trying to push Mesos on Windows features > forward. However, we all know the situation cannot be sustained well with > the high frequency of the regressions. > > To solve the issues, we’ve enabled two engineering system features for > Mesos on Windows to prevent regressions before and after each checkin, > > 1. *Windows reviewbot has been enabled to verify all of the tests on > windows for each PR.* For details, please refer to > https://reviews.apache.org/r/59116/ > <https://reviews.apache.org/r/59116/>. > > > 1. *Windows b**u**ild process has been added to CI system. *The build > status is posted to #windows channel by the CI bot after committing a > PR, > > > > The build regressions are generally caught manually (i.e. git pull && > cmake --build .) or when the CI bot posts a failure in the #windows > channel. For now, these build regressions don't get sent to the > bui...@mesos.apache.org mailing list due to the flakiness we're seeing in > the builds@ mailing list. > > For developers, if you do not have access to a Windows box, you have two > options: > 1. use the Windows Reviewbot. This runs in a loop (slightly different > than the Ubuntu Reviewbot) but both reviewbots function the same way. Just > push an update to the last review in a chain, and the reviewbot will get > around to it eventually. > > 2. Spin up a Windows box in Azure, AWS or some other cloud with Windows > Server 2016 + Docker + all the dependencies from > https://github.com/apache/mesos/blob/master/docs/windows.md > <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fapache%2Fmesos%2Fblob%2Fmaster%2Fdocs%2Fwindows.md&data=02%7C01%7Clil%40microsoft.com%7C80c4d083d18b427dea7f08d4a48e9a1d%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636314379756532237&sdata=h1phi6y%2BCD6%2B%2BzhyX6x7LrnhX8HGsM8gtUFUa3tkLPo%3D&reserved=0>. > > > *We highly recommend everyone to a**nalyze the Windows Reviewbot before > your checkins and monitor Windows build status after your checkins. * > > The above engineering system effort is just a starting point to prevent > the regressions. We also need help from our Mesos dev community – when you > checkin a fix, think about if there are some potential regressions on the > windows side and verify your fix on Windows as well; when you design a > feature, feel free to involve us in to your discussions and see how these > features should be designed for windows, etc. > > Only with your help, we can deliver Mesos to our Linux customers, and > Windows customers successfully. > > >
