@tommy while I understand the frustration, one big problem I have with doing reviews on GitHub is that the interface is really bad in terms of capturing revision sets across patch submissions and capturing dependencies across patches. Once a contributors updates an existing patch-set, all comments on the previous iteration of the patch-set are wiped out which makes it very painful for reviewers to understand the changes made on the patch-set in order to address the comments.
That's one reason to prefer RB at this pointw. That said I do agree that this is a barrier to entry for getting more contributors onto Mesos. Maybe we need an integration of RB with GitHub to make this process less painful. On Tue, Jun 6, 2017 at 7:18 PM, Gabriel Hartmann <gabr...@mesosphere.io> wrote: > +1 > > On Tue, Jun 6, 2017 at 7:13 PM Mao Geng <geng...@pinterest.com.invalid> > wrote: > > > Well said > > +1 to github > > > > > On Jun 6, 2017, at 6:59 PM, Klaus Ma <klaus1982...@gmail.com> wrote: > > > > > > +1 > > > > > >> On 7 Jun 2017, at 09:56, tommy xiao <xia...@gmail.com> wrote: > > >> > > >> Hi team, > > >> > > >> yesterday sometime, in a china local mesos developer group, a > Tencent's > > >> developer report a issue about docker executor fetcher can't correct > set > > >> file's owner. with detail chat, we found this is bug. So we guide the > > >> developer howto contributor to mesos project. in the same time, we > found > > >> the mesos contributor workflow is more old style than currently > Github's > > >> workflow. > > >> > > >> We know kubernetes's repo is based on github, more devel can easily > > >> participate in this project, but we need learn ASF's policy to use > > >> reviewBoard to discussion. my point is the workflow is ok, but the > > >> communicate is painful site in reviewborad, the learn curve is here, > not > > >> trivial. > > >> > > >> So proposal: > > >> > > >> quote from tim chen's chat in the chat group: > > >> > > >> "I think the current spark flow, where issues are in jira and code is > > >> happening in github is a good compromise" > > >> > > >> if you like it proposal, please +1 > > >> > > >> > > >> -- > > >> Deshi Xiao > > >> Twitter: xds2000 > > >> E-mail: xiaods(AT)gmail.com > > > > > > -- Avinash Sridharan, Mesosphere +1 (323) 702 5245
