Github user jpeach commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/248#discussion_r148843748
  
    --- Diff: src/master/validation.cpp ---
    @@ -298,7 +299,9 @@ Option<Error> reregisterSlave(
         const vector<FrameworkInfo>& frameworkInfos)
     {
       hashset<FrameworkID> frameworkIDs;
    -  hashset<ExecutorID> executorIDs;
    +
    +  typedef pair<FrameworkID, ExecutorID> IDPair;
    +  hashset<IDPair> executorIDs;
    --- End diff --
    
    Mesos doesn't use convenience typedefs.
    ```C
    hashset<pair<FrameworkID, ExecutorID>> executorIDs
    ```
    
    In subsequent lines, I believe that this is ok:
    ```
    auto id = std::make_pair(executor.framework_id(), executor.executor_id());
    ```


---

Reply via email to