Okay, Windows gets a special treatment : ). The aforementioned suggest does not apply to `TEST_F_TEMP_DISABLED_ON_WINDOWS`.
On Mon, Mar 26, 2018 at 3:21 AM, Andrew Schwartzmeyer < and...@schwartzmeyer.com> wrote: > Beware a large number of tickets from the Windows side... ;) > > > On 03/22/2018 12:22 am, Alex Rukletsov wrote: > >> I think such policy would help us discover and act on forgotten disabled >> tests. The reason I am reluctant to propose this as an official policy is >> because I don't know how to enforce it. >> >> On 21 Mar 2018 6:00 pm, "Vinod Kone" <vinodk...@gmail.com> wrote: >> >> Thanks for doing this Alex! Are you proposing a policy that every disabled >>> test should’ve an associated ticket that is linked in the comment above >>> the >>> test? I’m all for it. >>> >>> Sent from my phone >>> >>> > On Mar 21, 2018, at 9:42 AM, Alex Rukletsov <a...@mesosphere.io> >>> wrote: >>> > >>> > Folks, >>> > >>> > to increase visibility into disabled tests, I've added a >>> "disabled-test" >>> > label. Whenever you disable a test, please add this label. A TODO >>> comment >>> > before the test mentioning the corresponding jira helps too. >>> > >>> > At the moment we have 20+ disabled tests in 18 tickets [1]. Some tests >>> were >>> > disabled for a "brief period of time" before the release and stayed in >>> that >>> > state for years. It would be great to audit all of them and either fix >>> and >>> > re-enable or remove altogether. Any help is appreciated and volunteers >>> are >>> > sought! >>> > >>> > [1] https://issues.apache.org/jira/issues/?filter=12343497 >>> >>>
