Github user zhitaoli commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/283#discussion_r182227665
  
    --- Diff: src/slave/task_status_update_manager.cpp ---
    @@ -881,11 +881,21 @@ void TaskStatusUpdateStream::_handle(
         // Add it to the pending updates queue.
         pending.push(update);
       } else {
    -    // Record this ACK.
    -    acknowledged.insert(id::UUID::fromBytes(update.uuid()).get());
    +    StatusUpdate& pendingUpdate = pending.front();
     
    -    // Remove the corresponding update from the pending queue.
    -    pending.pop();
    +    if (pendingUpdate.uuid() == update.uuid()) {
    --- End diff --
    
    Can we use the _operator==()_ on the _id::UUID_ to compare the two fields 
instead?


---

Reply via email to