Can I ask why you are indexing the offers by hostname? Is it to better handle agent removal / unreachable signal?
Looking at the code <https://github.com/apache/mesos/blob/master/src/master/master.cpp#L11036> , I think master has the requested information (agent id, hostname) so we can include it in the rescind message! But there are couple things to discuss. The extra information to be included in rescind message is technically redundant. So we need to figure out a guideline on what information should be included / not included (e.g., should we include agent IP too) in such calls. Second, adding this extra information in v1 scheduler API would be relatively easy. But adding this to v0 API would be hard. Which API do you need to be updated? On Wed, May 2, 2018 at 10:31 AM, Varun Gupta <var...@uber.com> wrote: > Hi, > > Currently in our implementation we maintain two maps. > > Hostname -> []Offers > > offerID -> Hostname > > Second map is needed because rescind offers callback only provides offerid > and we need hostname to do performant lookup in first map. > > Is it feasible to add hostname or agentid in rescind offers? > > Thanks, > Varun >
