I have concerns about using a "string" type for the value in Quantity. I left comments and suggestions in the doc. Thanks!
On Mon, Dec 17, 2018 at 1:49 AM Meng Zhu <m...@mesosphere.com> wrote: > Hello: > > After discussing with folks, we want to propose to use `string` in the > `Quantity` message and also leave out the name at the moment: > > message Quantity { > required string value = 1; > } > > A sample use case for setting resource guarantee will be: > > message ResourceGuaranteeRequest { > optional string role = 1; > optional map<string, Quantity> resource_quantities = 2; > } > > I have updated the design doc here > < > https://docs.google.com/document/d/1WbRKmqsos1-IBJ9VjpT4kNIp2Peyvx2k4UphRaFVYFU/edit# > > > with more context, alternative proposals, and examples. Feel free leave > comments and questions. Thanks! > > -Meng > > On Tue, Dec 11, 2018 at 12:20 PM Meng Zhu <m...@mesosphere.com> wrote: > > > Hi: > > > > We are proposing to add a primitive type `Quantity` to facilitate several > > ongoing projects. The schema will be: > > > > message Quantity { > > required string name; > > optional value.scalar scalar; > > } > > > > You can find more details such as motivation, current, and future use > > cases in this design doc > > < > https://docs.google.com/document/d/1WbRKmqsos1-IBJ9VjpT4kNIp2Peyvx2k4UphRaFVYFU/edit?usp=sharing > >. > > Feel free leave comments and questions. > > > > Thanks, > > Meng > > > -- James DeFelice 585.241.9488 (voice) 650.649.6071 (fax)