-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29148/
-----------------------------------------------------------
Review request for MetaModel.
Bugs: METAMODEL-103
https://issues.apache.org/jira/browse/METAMODEL-103
Repository: metamodel
Description
-------
I made a whole lot of fixes to our javadoc to ensure that the javadoc linter
(new in Java 8) does not break a build with Javadocs enabled. There are still
javadoc warnings (which would be nice to get rid of) but no errors.
The way forward now to build javadoc is:
> mvn javadoc:aggregate
On my crummy old laptop that takes around 45 seconds.
Diffs
-----
cassandra/src/main/java/org/apache/metamodel/cassandra/package-info.java
PRE-CREATION
core/src/main/java/org/apache/metamodel/DataContext.java 28d5921
core/src/main/java/org/apache/metamodel/MetaModelHelper.java 4ee9798
core/src/main/java/org/apache/metamodel/QueryPostprocessDataContext.java
ab2dd71
core/src/main/java/org/apache/metamodel/convert/Converters.java 1be0e13
core/src/main/java/org/apache/metamodel/convert/DocumentConverter.java
f3669c4
core/src/main/java/org/apache/metamodel/convert/TypeConverter.java e49345e
core/src/main/java/org/apache/metamodel/create/CreateTable.java 9efe5b5
core/src/main/java/org/apache/metamodel/create/TableCreationBuilder.java
9ba0abe
core/src/main/java/org/apache/metamodel/data/AbstractDataSet.java d296735
core/src/main/java/org/apache/metamodel/data/AbstractRowBuilder.java fef04c9
core/src/main/java/org/apache/metamodel/data/DataSet.java 9c29860
core/src/main/java/org/apache/metamodel/data/DefaultRow.java 7ca1dfc
core/src/main/java/org/apache/metamodel/data/Document.java 3b1f254
core/src/main/java/org/apache/metamodel/data/DocumentSource.java 13bc952
core/src/main/java/org/apache/metamodel/data/IRowFilter.java e4271ab
core/src/main/java/org/apache/metamodel/data/Row.java d636343
core/src/main/java/org/apache/metamodel/data/RowBuilder.java 2843418
core/src/main/java/org/apache/metamodel/data/StyleBuilder.java d9edbc4
core/src/main/java/org/apache/metamodel/delete/AbstractRowDeletionBuilder.java
6f205d6
core/src/main/java/org/apache/metamodel/delete/RowDeletable.java aefc1dc
core/src/main/java/org/apache/metamodel/intercept/InterceptorList.java
b298305
core/src/main/java/org/apache/metamodel/intercept/package-info.java
PRE-CREATION
core/src/main/java/org/apache/metamodel/query/DefaultCompiledQuery.java
4cd497a
core/src/main/java/org/apache/metamodel/query/FilterClause.java fe981a1
core/src/main/java/org/apache/metamodel/query/FilterItem.java 9984401
core/src/main/java/org/apache/metamodel/query/FromClause.java 808886d
core/src/main/java/org/apache/metamodel/query/FromItem.java 8ee07fa
core/src/main/java/org/apache/metamodel/query/GroupByItem.java dcdba1e
core/src/main/java/org/apache/metamodel/query/OperatorType.java e668da8
core/src/main/java/org/apache/metamodel/query/OrderByItem.java 3fde53c
core/src/main/java/org/apache/metamodel/query/Query.java f46b007
core/src/main/java/org/apache/metamodel/query/SelectItem.java 6342676
core/src/main/java/org/apache/metamodel/query/builder/AbstractFilterBuilder.java
f14b4af
core/src/main/java/org/apache/metamodel/query/builder/FilterBuilder.java
8ba1f62
core/src/main/java/org/apache/metamodel/query/builder/SatisfiedQueryBuilder.java
2ca4efc
core/src/main/java/org/apache/metamodel/query/builder/WhereBuilder.java
2695142
core/src/main/java/org/apache/metamodel/query/parser/QueryParser.java 19af3f8
core/src/main/java/org/apache/metamodel/query/parser/SelectItemParser.java
16bb329
core/src/main/java/org/apache/metamodel/query/parser/package-info.java
PRE-CREATION
core/src/main/java/org/apache/metamodel/schema/ColumnTypeImpl.java 856321e
core/src/main/java/org/apache/metamodel/schema/MutableTable.java 904fc81
core/src/main/java/org/apache/metamodel/schema/Schema.java 903b640
core/src/main/java/org/apache/metamodel/schema/Table.java a36b6e6
core/src/main/java/org/apache/metamodel/schema/TableType.java d4f15dd
core/src/main/java/org/apache/metamodel/schema/builder/ColumnBuilder.java
d4d0a83
core/src/main/java/org/apache/metamodel/schema/builder/DocumentSourceProvider.java
355865d
core/src/main/java/org/apache/metamodel/schema/builder/InferentialColumnBuilder.java
2523f47
core/src/main/java/org/apache/metamodel/schema/builder/InferentialSchemaBuilder.java
84dedf1
core/src/main/java/org/apache/metamodel/schema/builder/InferentialTableBuilder.java
c2ad490
core/src/main/java/org/apache/metamodel/schema/builder/SchemaBuilder.java
33f6016
core/src/main/java/org/apache/metamodel/schema/builder/TableBuilder.java
b137c27
core/src/main/java/org/apache/metamodel/update/RowUpdateable.java 2c204fb
core/src/main/java/org/apache/metamodel/util/AbstractNumberAggregateBuilder.java
0df1fa7
core/src/main/java/org/apache/metamodel/util/AlphabeticSequence.java a4965e7
core/src/main/java/org/apache/metamodel/util/BaseObject.java 62f153d
core/src/main/java/org/apache/metamodel/util/ClasspathResource.java e9e1234
core/src/main/java/org/apache/metamodel/util/CollectionUtils.java 4fac86a
core/src/main/java/org/apache/metamodel/util/ConstantFunc.java 9a48516
core/src/main/java/org/apache/metamodel/util/ExclusionPredicate.java aec67c6
core/src/main/java/org/apache/metamodel/util/FalsePredicate.java f1f4a8e
core/src/main/java/org/apache/metamodel/util/FormatHelper.java bffc96d
core/src/main/java/org/apache/metamodel/util/ImmutableRef.java adfde04
core/src/main/java/org/apache/metamodel/util/InMemoryResource.java 3dafadf
core/src/main/java/org/apache/metamodel/util/InclusionPredicate.java d8aab91
core/src/main/java/org/apache/metamodel/util/LazyRef.java 6db947d
core/src/main/java/org/apache/metamodel/util/MutableRef.java c5010a1
core/src/main/java/org/apache/metamodel/util/Predicate.java ef585e7
core/src/main/java/org/apache/metamodel/util/Ref.java baa8e34
core/src/main/java/org/apache/metamodel/util/Resource.java f1a3dc3
core/src/main/java/org/apache/metamodel/util/ResourceUtils.java ad3426a
core/src/main/java/org/apache/metamodel/util/SerializableRef.java d3b56de
core/src/main/java/org/apache/metamodel/util/SimpleTableDef.java 0dd98a9
core/src/main/java/org/apache/metamodel/util/SimpleTableDefParser.java
7239321
core/src/main/java/org/apache/metamodel/util/TruePredicate.java f0d4745
core/src/main/java/org/apache/metamodel/util/UrlResource.java b0702aa
couchdb/src/main/java/org/apache/metamodel/couchdb/package-info.java daa8ba9
csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java 8c23b7a
csv/src/main/java/org/apache/metamodel/csv/CsvWriter.java 1d0b424
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContext.java
780631f
elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/package-info.java
PRE-CREATION
excel/src/main/java/org/apache/metamodel/excel/ExcelDataContext.java 2342e3c
fixedwidth/src/main/java/org/apache/metamodel/fixedwidth/FixedWidthDataContext.java
4876847
full/src/main/java/org/apache/metamodel/DataContextFactory.java f946356
hbase/src/main/java/org/apache/metamodel/hbase/ByteUtils.java 0a4d1bf
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c
jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcUtils.java a6065ae
jdbc/src/main/java/org/apache/metamodel/jdbc/QuerySplitter.java bbb09c9
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java
f83057e
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java
17140e3
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/package-info.java
PRE-CREATION
json/src/main/java/org/apache/metamodel/json/package-info.java PRE-CREATION
pojo/src/main/java/org/apache/metamodel/pojo/ObjectTableDataProvider.java
54c2a77
pojo/src/main/java/org/apache/metamodel/pojo/PojoDataContext.java 2de3d59
pojo/src/main/java/org/apache/metamodel/pojo/package-info.java PRE-CREATION
pom.xml b9e7f7f
salesforce/src/main/java/org/apache/metamodel/salesforce/SalesforceUtils.java
a8cec1f
salesforce/src/main/java/org/apache/metamodel/salesforce/package-info.java
PRE-CREATION
spring/src/main/java/org/apache/metamodel/spring/DataContextFactoryBean.java
ccf210e
spring/src/main/java/org/apache/metamodel/spring/SpringResource.java 4400859
spring/src/main/java/org/apache/metamodel/spring/package-info.java
PRE-CREATION
sugarcrm/src/main/java/org/apache/metamodel/sugarcrm/SugarCrmDataContext.java
22446fc
sugarcrm/src/main/java/org/apache/metamodel/sugarcrm/package-info.java
PRE-CREATION
xml/src/main/java/org/apache/metamodel/xml/XmlDomDataContext.java 4c1b5e4
Diff: https://reviews.apache.org/r/29148/diff/
Testing
-------
No impact was done on actual code. Tested the site build and javadoc:aggregate
on JDK6 and JDK8.
Thanks,
Kasper Sørensen