> On jan. 26, 2015, 8:25 a.m., Alberto Rodríguez wrote: > > Nice catch and good work in here! > > > > When creating the ElasticSearchDataContext, should we also double check > > that the index name is a proper ElasticSearch-syntax one? I think > > ElasticSearch does not allow some characters such as: \, /, *, ?... (see a > > detailed list in here: > > https://github.com/elasticsearch/elasticsearch/issues/6736) > > > > What do you think about this. > > Kasper Sørensen wrote: > Would be best to do if the ElasticSearch API offers a way to validate it. > Otherwise we need to ensure that our validation is always in sync with their > naming rules (I don't know if they might change, but just thinking they > might).
I'll commit as is - but more improvements are of course always welcome. - Kasper ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30256/#review69590 ----------------------------------------------------------- On jan. 25, 2015, 4:54 p.m., Kasper Sørensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30256/ > ----------------------------------------------------------- > > (Updated jan. 25, 2015, 4:54 p.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-106 > https://issues.apache.org/jira/browse/METAMODEL-106 > > > Repository: metamodel > > > Description > ------- > > My proposed fix for issue METAMODEL-106 > > > Diffs > ----- > > CHANGES.md 6717767 > > elasticsearch/src/main/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContext.java > 780631f > > Diff: https://reviews.apache.org/r/30256/diff/ > > > Testing > ------- > > > Thanks, > > Kasper Sørensen > >
