[ 
https://issues.apache.org/jira/browse/METAMODEL-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14386915#comment-14386915
 ] 

ASF GitHub Bot commented on METAMODEL-128:
------------------------------------------

GitHub user narahari92 opened a pull request:

    https://github.com/apache/metamodel/pull/13

    Fix for METAMODEL-128

    Please review the code fix for the mentioned defect. One test case gives 
false failure because we are comparing query's string form when an alias of 
item is used. I have modified that.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/narahari92/metamodel master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metamodel/pull/13.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #13
    
----
commit 4b7ade730734038503d29c5157fb842934f511a3
Author: Hosur Narahari <[email protected]>
Date:   2015-03-25T15:59:14Z

    changing select(expression) method of Query to support multiple columns and 
expressions in single string

commit a6684b9dde12e7766612a58940ab951bcf4f48c9
Author: Hosur Narahari <[email protected]>
Date:   2015-03-26T14:53:20Z

    change to select(expression) method of Query to have multiple expression in 
single method

commit 3436ef2bb487311ea563e0bab5e8b5986ec52327
Author: Hosur Narahari <[email protected]>
Date:   2015-03-26T14:57:31Z

    Unit test for issue METAMODEL-126

commit 6b13a57033c5e84f7f635c858d9531992e8b2780
Author: Hosur Narahari <[email protected]>
Date:   2015-03-28T15:38:53Z

    corrected the exprected and actual parameters location in method signature

commit 724bdc7a3a70fb70112b05165ee389d0b13d573a
Author: Hosur Narahari <[email protected]>
Date:   2015-03-29T05:20:07Z

    refactored select(expression) method of Query

commit 9238e8c4947385db8c046ef1e86cf6d90acf2ab2
Author: Hosur Narahari <[email protected]>
Date:   2015-03-29T13:24:03Z

    merging

commit a46b432a5fa0b326ab400e4c3510b61214152d79
Author: Hosur Narahari <[email protected]>
Date:   2015-03-30T15:20:51Z

    "Regular merge"Merge remote-tracking branch 'upstream/master'

commit 04f36b081cf9a657fb9462f9e9a87bb0c27ca284
Author: Hosur Narahari <[email protected]>
Date:   2015-03-30T15:42:36Z

    Fix for defect METAMODEL-128

commit 9b8f9f7d2d38bf8bdcdd7b2d15bee89d494c27a6
Author: Hosur Narahari <[email protected]>
Date:   2015-03-30T15:46:31Z

    Fix for defect METAMODEL-128

----


> Ordering on aggregation value not working
> -----------------------------------------
>
>                 Key: METAMODEL-128
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-128
>             Project: Apache MetaModel
>          Issue Type: Bug
>    Affects Versions: 4.3.2
>            Reporter: Ashish Mukherjee
>
> I am using a CSV Data Context example with multiple fields - occurrences, 
> first_name, last_name. 
> The query -
> SELECT SUM(persons.csv.occurrences) AS X, persons.csv.first_name FROM 
> ashish.persons.csv GROUP BY persons.csv.first_name ORDER BY X
> This query always orders the results by first_name and not the aggregation 
> value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to