Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/13#discussion_r27410445
--- Diff:
core/src/main/java/org/apache/metamodel/query/parser/SelectItemParser.java ---
@@ -160,6 +164,14 @@ public SelectItem findSelectItem(String expression)
throws MultipleSelectItemsPa
return new SelectItem(subQuerySelectItem, fromItem);
}
}
+
+ //if the expression is alias of some select item defined return
clone of that select item
+ List<SelectItem> allSelectItems =
MetaModelHelper.getAllSelectItems(_query);
+ for(SelectItem selectItem : allSelectItems) {
+ if(selectItem.getAlias() != null &&
selectItem.getAlias().equals(expressionCopy)) {
+ return selectItem.clone();
--- End diff --
Do we need to return the clone? Why not return the same select item? If it
is referred to by alias (like a kind of pass by reference) then I think it
makes sense to keep the same reference item and not a copy.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
