Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/14#discussion_r27895955
--- Diff:
core/src/main/java/org/apache/metamodel/create/AbstractTableCreationBuilder.java
---
@@ -123,9 +123,22 @@ public String toSql() {
&& !column.isNullable().booleanValue()) {
sb.append(" NOT NULL");
}
- if (column.isPrimaryKey()) {
- sb.append(" PRIMARY KEY");
- }
+ }
+ boolean primaryKeyExists = false;
+ for(int i = 0 ; i < columns.length ; i++) {
+ if(columns[i].isPrimaryKey()) {
+ if(!primaryKeyExists) {
+ sb.append(" ,PRIMARY KEY(");
--- End diff --
Heh, I meant the other space ... like we would normally write (space after
each comma, none before):
one, two, three
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
