Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/17#issuecomment-94541818
Hi Rafael,
Thank you for the contribution, really appreciate the work. I am aware of
the issue but I think this solution is a bit too fragile. It only reads the
first line to determine the data type and it also does type casting/narrowing
on each single value instead of trying to establish a data type and only narrow
according to that type. That essentially means that as a user I have no
guarantee that row 1 is going to have the same data types as row 2. That feels
very unsafe to me at least. I could effectively have a table with e.g. column
type NUMBER which would make sense on the first row but on the second row I
would get a String or something completely different.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
