-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34366/
-----------------------------------------------------------

Review request for MetaModel.


Bugs: METAMODEL-141
    https://issues.apache.org/jira/browse/METAMODEL-141


Repository: metamodel


Description
-------

Made the column type rewriting also aware of column size.
Added an Oracle dialect.
Made many adjustments to column type mapping based on information (wiki, DB 
manuals etc.) about which data types are missing/superceeded in various DBs.


Diffs
-----

  CHANGES.md cff4ce4 
  jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java 
c0a5999 
  jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java
 f83057e 
  jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DB2QueryRewriter.java 
03e9318 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/DefaultQueryRewriter.java 
1ac72bc 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/HsqldbQueryRewriter.java 
cc3d202 
  jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/IQueryRewriter.java 
17140e3 
  jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/MysqlQueryRewriter.java 
3c0037b 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/OracleQueryRewriter.java 
PRE-CREATION 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/PostgresqlQueryRewriter.java
 c3fd322 
  
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/SQLServerQueryRewriter.java
 d83d6d2 
  jdbc/src/test/java/org/apache/metamodel/dialects/DB2QueryRewriterTest.java 
9108461 
  jdbc/src/test/java/org/apache/metamodel/dialects/MysqlQueryRewriterTest.java 
f9aec48 
  
jdbc/src/test/java/org/apache/metamodel/dialects/SQLServerQueryRewriterTest.java
 fd55486 
  jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/OracleTest.java 
9794f4c 

Diff: https://reviews.apache.org/r/34366/diff/


Testing
-------

Only unittesting and some sparse manual testing in MySQL and PostgreSQL.
Not yet integration tested on MS SQL and Oracle.


Thanks,

Kasper Sørensen

Reply via email to