----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34401/#review84286 -----------------------------------------------------------
Ship it! Ship It! - Dennis Krøger On May 19, 2015, 9:13 a.m., Kasper Sørensen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34401/ > ----------------------------------------------------------- > > (Updated May 19, 2015, 9:13 a.m.) > > > Review request for MetaModel. > > > Bugs: METAMODEL-142 > https://issues.apache.org/jira/browse/METAMODEL-142 > > > Repository: metamodel > > > Description > ------- > > Ensured that the refreshing of schema objects inside the update callback > happens using the same JDBC connection as the running transaction is using > > > Diffs > ----- > > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcCreateTableBuilder.java > c0a5999 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDataContext.java a20924c > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcDropTableBuilder.java > aa3cc98 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcMetadataLoader.java > 54ad378 > jdbc/src/main/java/org/apache/metamodel/jdbc/JdbcSchema.java 043e477 > jdbc/src/main/java/org/apache/metamodel/jdbc/MetadataLoader.java 3e80426 > > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/AbstractJdbIntegrationTest.java > 6faec03 > > jdbc/src/test/java/org/apache/metamodel/jdbc/integrationtests/SQLServerJtdsDriverTest.java > 52219c0 > > Diff: https://reviews.apache.org/r/34401/diff/ > > > Testing > ------- > > Multiple unittests already around this. > Also added an integration test on SQL Server where this issue was causing > even a deadlock situation (because the JTDS driver would block the > refreshSchemas() call to wait until the transaction has finished). > > > Thanks, > > Kasper Sørensen > >
