[
https://issues.apache.org/jira/browse/METAMODEL-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14557415#comment-14557415
]
ASF GitHub Bot commented on METAMODEL-143:
------------------------------------------
GitHub user narahari92 opened a pull request:
https://github.com/apache/metamodel/pull/25
Metamodel143
Hi,
This is a fix for METAMODEL-143(Remove invalid characters from column names
depending on different data context).
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/narahari92/metamodel METAMODEL143
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit 6c78bc61cf3c459e4ac2335413baf1dbcf7e6975
Author: Hosur Narahari <[email protected]>
Date: 2015-05-23T16:13:19Z
METAMODEL-143 fix
commit 230f5c8a41f41f178a4365c99cd5041c3b851299
Author: Hosur Narahari <[email protected]>
Date: 2015-05-23T16:18:42Z
METAMODEL-143 fix
----
> Escape/normalize column names in create table operations
> --------------------------------------------------------
>
> Key: METAMODEL-143
> URL: https://issues.apache.org/jira/browse/METAMODEL-143
> Project: Apache MetaModel
> Issue Type: Bug
> Reporter: Kasper Sørensen
>
> For many applications (at least the one I am working on ;-)) the column names
> in a MetaModel CREATE TABLE operation may be dynamically provided for
> instance by the UI or by some other mechanism in the application. For those
> external parts it may be close to impossible to figure out if a particular
> column name is valid or not. For instance in JDBC databases it's typically
> not allowed with whitespaces in column names, whereas it is allowed in some
> NoSQL and file-based datastores.
> Wouldn't it be smarter then that we make this validation (and potential
> on-the-fly normalization) a responsibility of the backing DataContext. For
> instance, in JDBC module we could ensure that whitespace is replaced by
> underscore and that other special characters maybe also get some special
> treatment.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
