[ 
https://issues.apache.org/jira/browse/METAMODEL-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624049#comment-14624049
 ] 

Kasper Sørensen commented on METAMODEL-156:
-------------------------------------------

Hi again,

A jira comment is not really an ideal place to do code review. Could you post 
either on our review board or as a github pull request? And from the bit I 
understand from the code: It would probably be good to break up the method so 
that we can unittest the relevant part here - I imagine a method called 
something like "determineDefaultSchemaFromJdbcUrl(String[] schemaNames, String 
url)" - and then we could unittest it without needing to do integration tests.

> JdbcDataContext.getDefaultSchemaName  return SchemaName error
> -------------------------------------------------------------
>
>                 Key: METAMODEL-156
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-156
>             Project: Apache MetaModel
>          Issue Type: Bug
>    Affects Versions: 4.2.0-incubating, 4.3.0-incubating, 4.3.2
>         Environment: windows 7 64  bit eclipse 4.2 luna
>            Reporter: zhaoweijing
>              Labels: starter
>             Fix For: 4.2.0-incubating, 4.3.0-incubating, 4.3.2
>
>
> my database has three mysql databases, for example, baseFW, baseFW_test, 
> test. when my mysql url is : http:///3306?baseFW_test, and i want get 
> baseFW_test jdbccontext,but i will get baseFW jdbccontext. because 
> indexOf("baseFW") >0 ,so return first baseFW.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to