GitHub user ardlema opened a pull request:
https://github.com/apache/metamodel/pull/34
Refactoring to support scalar function
The current code only supports aggregate functions. In order to support
more type of functions such as scalar we need to do some refactor.
The changes made in this PR include:
- The FunctionType is now an interface which has static final references
to the aggregate functions.
- New AggregateFunction interface that contains the aggregation specific
methods
- New DefaultAggregateFunction which implements the AggregateFunction
interface
- ScalarFunction interface which is an skeleton where we should add the
new scalar functions
- FunctionTypeFactory that creates AggregateFunctions from its name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ardlema/metamodel METAMODEL-165
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/34.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #34
----
commit ba6a04fa2bd00697c1ce2dfde3eb0332711cf24e
Author: Alberto Rodriguez <[email protected]>
Date: 2015-07-27T08:41:23Z
Refactoring to generalize functions support
commit 9301a8e6f833985e80e4978008249c7d7d308279
Author: Alberto Rodriguez <[email protected]>
Date: 2015-07-27T09:14:01Z
Fixed failing tests: build method returns now a new instance of aggregate
builders
commit b053029f1167a8c9977aa1d1b5edd1c245e754d4
Author: Alberto Rodriguez <[email protected]>
Date: 2015-07-27T09:26:36Z
Added some JavaDoc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
