Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/34#issuecomment-129258186
Added a bunch of new remarks. I have been pretty meticulous in checking the
PR mostly because it is an API change, so I hope it's encouraging and does not
feel like critisism. It looks quite good now, and if you agree on the remarks I
have left then I will give it my +1 for sure :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
