GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/47
Converted OperatorType from an enum to an interface
This branch is not yet functional, _but_ I wanted to raise the idea of
making OperatorType an interface instead of an enum. We recently did the same
with FunctionType and it enables us to potentially plug in new implementations
without breaking backwards compatibiltity. In the case of OperatorType I
imagine that some custome operators could be plugged in to support custom cases.
I didn't quite finish this PR/branch yet because I ran into problems. The
main one being deserialization of old OperatorType enum objects. I think this
can be overcome with a hack a la the thing we have with LegacyColumnType.
Another issue is to get rid of any remaining switch-case blocks which rely
on OperatorType to be an enum.
But before handling those issues I wanted to take the temperature in the
community - is this good/worth doing?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel
feature/operator-as-interface
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/47.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #47
----
commit 052fa28586efe39c833a90d973505949dd504594
Author: Kasper Sørensen <[email protected]>
Date: 2015-08-25T08:47:10Z
Converted OperatorType from an enum to an interface
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
