Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/48#discussion_r38647125
--- Diff:
elasticsearch/src/test/java/org/apache/metamodel/elasticsearch/ElasticSearchDataContextTest.java
---
@@ -559,7 +560,16 @@ private static void indexBulkDocuments(String
indexName, String indexType, int n
}
- private static void indexOneTweeterDocumentPerIndex(String indexType,
int id) {
+ private static void indexTweeterDocument(String indexType, int id,
Date date) {
+ try {
+ client.prepareIndex(indexName,
indexType).setSource(buildTweeterJson(id, date))
+ .setId("tweet_" + indexType + "_" +
id).execute().actionGet();
+ } catch (Exception ex) {
+ System.out.println("Exception indexing documents!!!!!");
--- End diff --
I completely agree (except I wouldn't rethrow, but use throws instead), but
it seemed to be the pattern for all the indexing methods here, so I just went
with the flow :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
