Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/50#issuecomment-144962195
hmm something's odd here. You PR is suggesting we add this to the 4.0.x
branch while it should probably do it on the master branch.
If I add the patch to my master branch then my build fails with the
following issue:
```
Failed tests:
FormatHelperTest.testNumberFormat:32 expected:<987643.21[]> but
was:<987643.21[3456343]>
Tests run: 281, Failures: 1, Errors: 0, Skipped: 0
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] MetaModel .......................................... SUCCESS [
4.185 s]
[INFO] MetaModel core API ................................. FAILURE [
13.168 s]
[INFO] MetaModel module for collection and POJO-based DataContexts. SKIPPED
[INFO] MetaModel module for fixed width value files ....... SKIPPED
[INFO] MetaModel module for Excel spreadsheets ............ SKIPPED
[INFO] MetaModel module for comma-separated value (CSV) files SKIPPED
[INFO] MetaModel module for JSON files .................... SKIPPED
[INFO] MetaModel module for XML files ..................... SKIPPED
[INFO] MetaModel module for relational JDBC databases ..... SKIPPED
[INFO] MetaModel module for Elasticsearch analytics engine SKIPPED
[INFO] MetaModel module for Apache Hadoop, HDFS, YARN integration SKIPPED
[INFO] MetaModel module for Apache HBase .................. SKIPPED
[INFO] MetaModel module for Apache Cassandra database ..... SKIPPED
[INFO] MetaModel module for MongoDB databases ............. SKIPPED
[INFO] MetaModel module for CouchDB databases ............. SKIPPED
[INFO] MetaModel module for OpenOffice.org database files . SKIPPED
[INFO] MetaModel module for Salesforce.com ................ SKIPPED
[INFO] MetaModel module for SugarCRM ...................... SKIPPED
[INFO] MetaModel full package, including DataContext factories SKIPPED
[INFO] MetaModel module for Spring enabled configuration .. SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
