[
https://issues.apache.org/jira/browse/METAMODEL-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14941570#comment-14941570
]
ASF GitHub Bot commented on METAMODEL-182:
------------------------------------------
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/53
METAMODEL-182: getSize() and getLastModified() on directory-based resource
So far only fixed for FileResource.
TODO: Also implement for HdfsResource.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel METAMODEL-182
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 1becafbd6ad43f8dcce0c6c6c96a63d37b6667be
Author: Kasper Sørensen <[email protected]>
Date: 2015-10-02T18:58:29Z
METAMODEL-182: Fixed for FileResource
----
> Directory-based (File/Hdfs)Resource doesn't properly implement getSize() and
> getLastModified()
> ----------------------------------------------------------------------------------------------
>
> Key: METAMODEL-182
> URL: https://issues.apache.org/jira/browse/METAMODEL-182
> Project: Apache MetaModel
> Issue Type: Bug
> Reporter: Kasper Sørensen
>
> We managed to implement nice reading of directory-based resources with
> FileResource and HdfsResource, but it seems that we forgot to take a look at
> some of the additional methods on the Resource interface.
> Especially if you look at the getSize() and getLastModified() methods,
> nothing changed and I am sure this doesn't work as expected when the
> underlying file/path is a directory instead of a single file.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
