[
https://issues.apache.org/jira/browse/METAMODEL-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14948191#comment-14948191
]
ASF GitHub Bot commented on METAMODEL-194:
------------------------------------------
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/57
Support for Max Rows / Limit = 0
Fixes the max rows = 0 support in MetaModel, see METAMODEL-194.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel
METAMODEL-194-max-rows-0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/57.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #57
----
commit 70ab796eeed3ca238253cea9adb15fdf6314b4b5
Author: Kasper Sørensen <[email protected]>
Date: 2015-10-08T07:16:24Z
METAMODEL-194: Fixed
----
> Max rows property of query cannot be 0
> --------------------------------------
>
> Key: METAMODEL-194
> URL: https://issues.apache.org/jira/browse/METAMODEL-194
> Project: Apache MetaModel
> Issue Type: Bug
> Reporter: Kasper Sørensen
>
> Query.setMaxRows(Integer) has a check to see that the value is correct. But
> for some reason it does not allow max rows = 0. In my opinion it should be
> possible to define and execute a query with max rows = 0. It would just
> always return an empty DataSet. But from our perspective we shouldn't
> prohibit it becuase the query may be created by some tool or dynamic code in
> which case allowing 0 may make sense.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
