[
https://issues.apache.org/jira/browse/METAMODEL-204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14976004#comment-14976004
]
ASF GitHub Bot commented on METAMODEL-204:
------------------------------------------
Github user LosD commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/66#discussion_r43093927
--- Diff:
jdbc/src/main/java/org/apache/metamodel/jdbc/dialects/AbstractQueryRewriter.java
---
@@ -280,6 +280,12 @@ protected String rewriteSelectClause(Query query,
SelectClause selectClause) {
}
protected String rewriteSelectItem(Query query, SelectItem item) {
+ if (item.isFunctionApproximationAllowed()) {
+ // function approximation is not included in any standard SQL
+ // constructions - will have to be overridden by subclasses if
there
+ // are specialized dialects for it.
+ item = item.replaceFunctionApproximationAllowed(false);
+ }
--- End diff --
Nope, it's removing it, so that it doesn't end up in end at i.e. JDBC
contexts
> JDBC module does not rewrite newly introduced "APPROXIMATE" keyword
> -------------------------------------------------------------------
>
> Key: METAMODEL-204
> URL: https://issues.apache.org/jira/browse/METAMODEL-204
> Project: Apache MetaModel
> Issue Type: Bug
> Reporter: Kasper Sørensen
> Assignee: Kasper Sørensen
> Priority: Critical
> Fix For: 4.4.1
>
>
> The newly introduced APPROXIMATE keyword (from METAMODEL-200) is passed on to
> the underlying database's SQL query in the JDBC module.
> Discovered via debug in JdbcDataContext line 432 where "queryString" has
> value like:
> {code}
> SELECT APPROXIMATE COUNT(*) FROM PUBLIC."CUSTOMERS"
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
