[
https://issues.apache.org/jira/browse/METAMODEL-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15089107#comment-15089107
]
ASF GitHub Bot commented on METAMODEL-183:
------------------------------------------
Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/86#discussion_r49181994
--- Diff:
mongodb/common/src/main/java/org/apache/metamodel/mongodb/common/MongoDBUtils.java
---
@@ -73,5 +101,29 @@ private static Object toValue(Column column, Object
value) {
}
return value;
}
+
+ public static Object covertArrayToList(Object arr) {
--- End diff --
Could we make this method private and just call it in the toValue(...)
method instead? Since the method is really restricted in it's use it seems
maybe we can add an ```if``` above and then not worry about other people
misunderstanding what this is used for.
Small note on naming - it's misspelled (missing "n" in convert).
> For Mongo DB model, use new APIs instead of old ones.
> -----------------------------------------------------
>
> Key: METAMODEL-183
> URL: https://issues.apache.org/jira/browse/METAMODEL-183
> Project: Apache MetaModel
> Issue Type: Improvement
> Reporter: Hosur Narahari
> Priority: Minor
>
> I observed that we are using old APIs of MongoDB in our metamodel project,
> like Mongo instead of MongoClient, DB instead of MongoDatabase and many more.
> It would be better if we replace this with new API as support for Mongo
> driver would be for the new one.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
