Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/85#discussion_r49462089
--- Diff: core/src/main/java/org/apache/metamodel/query/SelectItem.java ---
@@ -461,8 +472,11 @@ public StringBuilder toStringNoAlias() {
public StringBuilder toStringNoAlias(boolean
includeSchemaInColumnPath) {
final StringBuilder sb = new StringBuilder();
if (_column != null) {
- sb.append(getToStringColumnPrefix(includeSchemaInColumnPath));
- sb.append(_column.getQuotedName());
+ if (_function==null ||
+ (_function!=null &&
!_function.getFunctionName().equals(FunctionType.CONCAT.getFunctionName()))) {
--- End diff --
Unclear to me why this is needed. I would prefer this to be really agnostic
of function type. Any function should be able to have a mix of parameter types
(if that is somehow the reason for this if - I'm unsure).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
