[ 
https://issues.apache.org/jira/browse/METAMODEL-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258730#comment-15258730
 ] 

ASF GitHub Bot commented on METAMODEL-244:
------------------------------------------

Github user LosD commented on the pull request:

    https://github.com/apache/metamodel/pull/96#issuecomment-214856085
  
    Looks good! Maybe I'd let the test be 
DelegatingIntrinsicSwitchColumnNamingStrategyTest. That it is the default is 
maybe less relevant for the test than what it really is testing. But that's up 
to you, not a deal breaker for me.



> Ability to specify column names for datastores that may not have named columns
> ------------------------------------------------------------------------------
>
>                 Key: METAMODEL-244
>                 URL: https://issues.apache.org/jira/browse/METAMODEL-244
>             Project: Apache MetaModel
>          Issue Type: New Feature
>            Reporter: Kasper Sørensen
>            Assignee: Kasper Sørensen
>
> Some datastores don't necesarily define the column names/headers, just the 
> data. Therefore it is sometimes needed to define column names manually - or 
> even via some pluggable interface that would allow a custom naming strategy.
> I can think of the following modules where this would be relevant:
>  * csv
>  * fixed-width
>  * excel



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to