Github user LosD commented on a diff in the pull request:

    https://github.com/apache/metamodel/pull/98#discussion_r61165846
  
    --- Diff: 
elasticsearch/common/src/main/java/org/apache/metamodel/elasticsearch/common/ElasticSearchUtils.java
 ---
    @@ -95,17 +103,49 @@ public static QueryBuilder getExistsQuery(String 
fieldName) {
                     // do nothing - the ID is a client-side construct
                     continue;
                 }
    -            sourceProperties.add(columnName);
    +            
    +            final String fieldName = getValidatedFieldName(columnName);
    +            final Map<String, String> propertyMap = new HashMap<>();
    +            final String type = getType(column);
    +            propertyMap.put("type", type);
    +//            propertyMap.put("store", "true");
    --- End diff --
    
    How come this is commented out? Don't we want to ensure storage?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to