Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/104#discussion_r64326605
--- Diff: csv/src/main/java/org/apache/metamodel/csv/CsvDataContext.java ---
@@ -244,7 +227,7 @@ private static File
createFileFromInputStream(InputStream inputStream, String en
file = fileCandidate;
final BufferedWriter writer = FileHelper.getBufferedWriter(file,
encoding);
- final BufferedReader reader = new BufferedReader(new
InputStreamReader(inputStream));
+ final BufferedReader reader = new BufferedReader(new
InputStreamReader(inputStream, Charset.forName(encoding)));
--- End diff --
For the sake of consistency, would it be nicer to use
`FileHelper.getBufferedReader(inputStream, encoding)`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
