Github user LosD commented on the pull request:

    
https://github.com/apache/metamodel/commit/8e2ff7167eeae456a1e307426407e262dd7297f8#commitcomment-17748904
  
    In 
service-webapp/src/main/java/org/apache/metamodel/service/controllers/TenantController.java:
    In 
service-webapp/src/main/java/org/apache/metamodel/service/controllers/TenantController.java
 on line 64:
    If you want to use the name as the identifier, PUT is correct, but this 
makes me think that other implementations could be allowed to use other 
identifiers, and then PUT would be wrong.
    
    If the (user visible) identifier is the name by definition, I'd reinforce 
that by explicitly putting the input name here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to