Github user kaspersorensen commented on a diff in the pull request:
https://github.com/apache/metamodel/pull/109#discussion_r66380066
--- Diff: excel/src/main/java/org/apache/metamodel/excel/ExcelUtils.java ---
@@ -108,7 +108,9 @@ public static Workbook readWorkbook(Resource resource) {
if (resource instanceof FileResource) {
final File file = ((FileResource) resource).getFile();
try {
- return WorkbookFactory.create(file);
+ final FileInputStream inputStream = new
FileInputStream(file);
+ final Workbook workbook =
WorkbookFactory.create(inputStream);
--- End diff --
I'm pretty sure this will harm performance rather than improve it.
WorkbookFactory has a specific create-method that takes a File because that
enables it to use RandomAccessFile when working with it, rather than having to
sequence through it like an input stream.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
